[GitHub] [bookkeeper] dlg99 commented on a diff in pull request #3889: [improve] [client] Group read/write response when jumping to the ordered executor

["dlg99 (via GitHub)" <gi...@apache.org>]

dlg99 commented on code in PR #3889:
URL: https://github.com/apache/bookkeeper/pull/3889#discussion_r1152790493


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java:
##########
@@ -1341,7 +1349,10 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception
 
         if (msg instanceof BookieProtocol.Response) {
             BookieProtocol.Response response = (BookieProtocol.Response) msg;
-            readV2Response(response);
+            if (!responses.offer(response)) {

Review Comment:
   It will increase the latency of the latency-sensitive workloads.
   At least this has to be behind a feature flag.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org