You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "laskoviymishka (via GitHub)" <gi...@apache.org> on 2026/04/13 18:33:03 UTC
[PR] docs: expand CONTRIBUTING.md with issue claiming and PR guidelines [iceberg-go]
laskoviymishka opened a new pull request, #887:
URL: https://github.com/apache/iceberg-go/pull/887
Add a contribution guideline rules for new-contributors, especially how to claim issue, work with reviews and where to seek for feedback and ping people.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] docs: expand CONTRIBUTING.md with issue claiming and PR guidelines [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #887:
URL: https://github.com/apache/iceberg-go/pull/887#discussion_r3075037972
##########
CONTRIBUTING.md:
##########
@@ -20,4 +20,45 @@
## Get in Touch
- [Iceberg community](https://iceberg.apache.org/community/)
-- [Iceberg-Go Slack](https://apache-iceberg.slack.com/archives/C05J3MJ42BD)
\ No newline at end of file
+- [Iceberg-Go Slack](https://apache-iceberg.slack.com/archives/C05J3MJ42BD)
+
+## Picking Up Issues
+
+Before starting work on an issue:
+
+1. **Check for existing PRs.** Search the [open pull requests](https://github.com/apache/iceberg-go/pulls) to make sure nobody is already working on it.
+2. **Claim the issue.** Leave a comment on the issue (e.g., "I'd like to work on this") and wait for a maintainer to acknowledge before writing code.
+3. **One at a time for new contributors.** If you haven't had a PR merged into iceberg-go yet, please work on one issue at a time. Get it reviewed, address feedback, get it merged — then pick up the next one. This helps us give your work the attention it deserves and avoids wasted effort from overlapping contributions.
+
+If two PRs land for the same issue, we will generally keep the one from the contributor who claimed it first.
+
+## Submitting a Pull Request
+
+- Reference the issue number in your PR description (e.g., "Fixes #123").
+- Keep PRs focused — one issue per PR.
+- Run `go test ./...` and `gofmt` before pushing.
Review Comment:
should we tell them to run `golangci-lint`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] docs: expand CONTRIBUTING.md with issue claiming and PR guidelines [iceberg-go]
Posted by "laskoviymishka (via GitHub)" <gi...@apache.org>.
laskoviymishka commented on code in PR #887:
URL: https://github.com/apache/iceberg-go/pull/887#discussion_r3075072332
##########
CONTRIBUTING.md:
##########
@@ -20,4 +20,45 @@
## Get in Touch
- [Iceberg community](https://iceberg.apache.org/community/)
-- [Iceberg-Go Slack](https://apache-iceberg.slack.com/archives/C05J3MJ42BD)
\ No newline at end of file
+- [Iceberg-Go Slack](https://apache-iceberg.slack.com/archives/C05J3MJ42BD)
+
+## Picking Up Issues
+
+Before starting work on an issue:
+
+1. **Check for existing PRs.** Search the [open pull requests](https://github.com/apache/iceberg-go/pulls) to make sure nobody is already working on it.
+2. **Claim the issue.** Leave a comment on the issue (e.g., "I'd like to work on this") and wait for a maintainer to acknowledge before writing code.
+3. **One at a time for new contributors.** If you haven't had a PR merged into iceberg-go yet, please work on one issue at a time. Get it reviewed, address feedback, get it merged — then pick up the next one. This helps us give your work the attention it deserves and avoids wasted effort from overlapping contributions.
+
+If two PRs land for the same issue, we will generally keep the one from the contributor who claimed it first.
+
+## Submitting a Pull Request
+
+- Reference the issue number in your PR description (e.g., "Fixes #123").
+- Keep PRs focused — one issue per PR.
+- Run `go test ./...` and `gofmt` before pushing.
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] docs: expand CONTRIBUTING.md with issue claiming and PR guidelines [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #887:
URL: https://github.com/apache/iceberg-go/pull/887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] docs: expand CONTRIBUTING.md with issue claiming and PR guidelines [iceberg-go]
Posted by "laskoviymishka (via GitHub)" <gi...@apache.org>.
laskoviymishka commented on code in PR #887:
URL: https://github.com/apache/iceberg-go/pull/887#discussion_r3075060954
##########
CONTRIBUTING.md:
##########
@@ -20,4 +20,45 @@
## Get in Touch
- [Iceberg community](https://iceberg.apache.org/community/)
-- [Iceberg-Go Slack](https://apache-iceberg.slack.com/archives/C05J3MJ42BD)
\ No newline at end of file
+- [Iceberg-Go Slack](https://apache-iceberg.slack.com/archives/C05J3MJ42BD)
+
+## Picking Up Issues
+
+Before starting work on an issue:
+
+1. **Check for existing PRs.** Search the [open pull requests](https://github.com/apache/iceberg-go/pulls) to make sure nobody is already working on it.
+2. **Claim the issue.** Leave a comment on the issue (e.g., "I'd like to work on this") and wait for a maintainer to acknowledge before writing code.
+3. **One at a time for new contributors.** If you haven't had a PR merged into iceberg-go yet, please work on one issue at a time. Get it reviewed, address feedback, get it merged — then pick up the next one. This helps us give your work the attention it deserves and avoids wasted effort from overlapping contributions.
+
+If two PRs land for the same issue, we will generally keep the one from the contributor who claimed it first.
+
+## Submitting a Pull Request
+
+- Reference the issue number in your PR description (e.g., "Fixes #123").
+- Keep PRs focused — one issue per PR.
+- Run `go test ./...` and `gofmt` before pushing.
Review Comment:
yes, right, it's running in CI (i always forgot about this linter and have to re-push stuff due to CI failures)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org