[GitHub] [yunikorn-core] manirajv06 commented on a diff in pull request #407: [YUNIKORN-1183] pre-select node for daemon set pod

[GitBox <gi...@apache.org>]

manirajv06 commented on code in PR #407:
URL: https://github.com/apache/yunikorn-core/pull/407#discussion_r881511714


##########
pkg/scheduler/objects/application.go:
##########
@@ -844,6 +850,27 @@ func (sa *Application) tryAllocate(headRoom *resources.Resource, nodeIterator fu
 			}
 			continue
 		}
+
+		requiredNode := request.GetRequiredNode()
+		// does request (daemon set pods?) has any constraint to run on specific node?
+		if requiredNode != "" {
+			node := getnode(requiredNode)
+			alloc := sa.tryNode(node, request)

Review Comment:
   No, We shouldn't call the method as it is not required for daemon set pod and this `if` block is meant for daemon set pod only. Hence the removal of `isValidFor` method. There could be a situation wherein running a type of daemon set pods itself is mandatory to make the node as "schedulable/ready".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org