You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/12 02:51:35 UTC
[GitHub] [spark] sarutak commented on a change in pull request #34561: [SPARK-37294][SQL][TESTS] Check inserting of ANSI intervals into a table partitioned by the interval columns
sarutak commented on a change in pull request #34561:
URL: https://github.com/apache/spark/pull/34561#discussion_r747945560
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -2915,6 +2915,40 @@ class DataSourceV2SQLSuite
}
}
+ test("SPARK-37294: insert ANSI intervals into a table partitioned by the interval columns") {
+ val tbl = "testpart.interval_table"
+ Seq(PartitionOverwriteMode.DYNAMIC.toString,
+ PartitionOverwriteMode.STATIC.toString).foreach { mode =>
+ withSQLConf(SQLConf.PARTITION_OVERWRITE_MODE.key -> mode) {
+ withTable(tbl) {
+ sql(
+ s"""
+ |CREATE TABLE $tbl (i int, part1 INTERVAL YEAR, part2 INTERVAL DAY) USING $v2Format
Review comment:
`i INT`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org