[GitHub] spark pull request #16355: [SPARK-16473][MLLIB] Fix BisectingKMeans Algorith...

[jkbradley <gi...@git.apache.org>]

Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16355#discussion_r95001382
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/clustering/BisectingKMeansSuite.scala ---
    @@ -29,9 +29,12 @@ class BisectingKMeansSuite
       final val k = 5
       @transient var dataset: Dataset[_] = _
     
    +  @transient var sparseDataset: Dataset[_] = _
    +
       override def beforeAll(): Unit = {
         super.beforeAll()
         dataset = KMeansSuite.generateKMeansData(spark, 50, 3, k)
    +    sparseDataset = KMeansSuite.generateSparseData(spark, 100, 1000, k, 42)
    --- End diff --
    
    Does the test really need to be this large?  It takes ~1 sec which is long-ish for a unit test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org