[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #588: fix:fail all pending requests when occurs ServerError_TopicTerminated…

[GitBox <gi...@apache.org>]

cckellogg commented on a change in pull request #588:
URL: https://github.com/apache/pulsar-client-go/pull/588#discussion_r685737506



##########
File path: pulsar/internal/connection.go
##########
@@ -697,6 +697,16 @@ func (c *connection) deletePendingRequest(requestID uint64) (*request, bool) {
 	return request, ok
 }
 
+func (c *connection) failPendingRequests(errMsg string) bool {

Review comment:
       Is the return value used?
   
   There is some duplicate code around line 370 (https://github.com/apache/pulsar-client-go/blob/master/pulsar/internal/connection.go#L370) that might benefit from this function. Maybe it can take an `err Error` as an argument instead of a string.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org