You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/18 08:13:39 UTC
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3185: optimizer: add framework for the rule of pre-add cast to the literal in comparison binary
codecov-commenter commented on PR #3185:
URL: https://github.com/apache/arrow-datafusion/pull/3185#issuecomment-1219172581
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3185?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3185](https://codecov.io/gh/apache/arrow-datafusion/pull/3185?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (597d694) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/89bcfc4827a84c37abdf6476ec164611b270492d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (89bcfc4) will **increase** coverage by `0.00%`.
> The diff coverage is `82.94%`.
> :exclamation: Current head 597d694 differs from pull request most recent head 5fe6e26. Consider uploading reports for the commit 5fe6e26 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3185 +/- ##
========================================
Coverage 85.85% 85.85%
========================================
Files 291 292 +1
Lines 52786 53008 +222
========================================
+ Hits 45320 45511 +191
- Misses 7466 7497 +31
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/3185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/core/tests/sql/subqueries.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL3NxbC9zdWJxdWVyaWVzLnJz) | `94.32% <ø> (ø)` | |
| [datafusion/core/tests/provider\_filter\_pushdown.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL3Byb3ZpZGVyX2ZpbHRlcl9wdXNoZG93bi5ycw==) | `75.60% <11.11%> (-9.33%)` | :arrow_down: |
| [...sical-expr/src/aggregate/approx\_percentile\_cont.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9waHlzaWNhbC1leHByL3NyYy9hZ2dyZWdhdGUvYXBwcm94X3BlcmNlbnRpbGVfY29udC5ycw==) | `81.43% <65.21%> (-3.53%)` | :arrow_down: |
| [datafusion/core/tests/sql/explain\_analyze.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL3NxbC9leHBsYWluX2FuYWx5emUucnM=) | `83.39% <66.66%> (ø)` | |
| [datafusion/core/src/physical\_plan/hash\_utils.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL2hhc2hfdXRpbHMucnM=) | `40.05% <71.42%> (ø)` | |
| [...tafusion/physical-expr/src/expressions/datetime.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9waHlzaWNhbC1leHByL3NyYy9leHByZXNzaW9ucy9kYXRldGltZS5ycw==) | `84.22% <80.00%> (ø)` | |
| [...optimizer/src/pre\_cast\_lit\_in\_binary\_comparison.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9vcHRpbWl6ZXIvc3JjL3ByZV9jYXN0X2xpdF9pbl9iaW5hcnlfY29tcGFyaXNvbi5ycw==) | `85.84% <85.84%> (ø)` | |
| [datafusion/core/src/execution/context.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9leGVjdXRpb24vY29udGV4dC5ycw==) | `78.26% <100.00%> (+0.20%)` | :arrow_up: |
| [datafusion/core/tests/sql/aggregates.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL3NxbC9hZ2dyZWdhdGVzLnJz) | `99.37% <100.00%> (+0.01%)` | :arrow_up: |
| [datafusion/expr/src/aggregate\_function.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3185/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9hZ2dyZWdhdGVfZnVuY3Rpb24ucnM=) | `93.45% <100.00%> (+1.15%)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/arrow-datafusion/pull/3185/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org