[GitHub] [pinot] klsince commented on a diff in pull request #10705: Check if serverTags as configured in tierConfigs are valid

["klsince (via GitHub)" <gi...@apache.org>]

klsince commented on code in PR #10705:
URL: https://github.com/apache/pinot/pull/10705#discussion_r1182719683


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1639,6 +1639,17 @@ void validateTableTenantConfig(TableConfig tableConfig) {
             "Failed to find instances with tag: " + tag + " for table: " + tableNameWithType);
       }
     }
+    // Check if serverTags as configured in tierConfigs are valid.
+    List<TierConfig> tierConfigList = tableConfig.getTierConfigsList();
+    if (CollectionUtils.isNotEmpty(tierConfigList)) {
+      for (TierConfig tierConfig : tierConfigList) {
+        if (getInstancesWithTag(tierConfig.getServerTag()).isEmpty()) {

Review Comment:
   I think it gets all instances for the check. btw, this is the same check done for table tenant L1640.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org