You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2016/05/10 23:40:12 UTC

Review Request 47201: removed @Retained from getValueInVM since its result is never off-heap

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47201/
-----------------------------------------------------------

Review request for geode, Eric Shu, Ken Howe, and Sai Boorlagadda.


Bugs: GEODE-1289
    https://issues.apache.org/jira/browse/GEODE-1289


Repository: geode


Description
-------

removed @Retained from getValueInVM since its result is never off-heap


Diffs
-----

  geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/AbstractIndex.java 96e83b26e00f701e86c900ed44664e93f826e0c9 
  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java 46a851dfbae3641925b1529f2da562d9feca57e4 
  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 75a1e3270793824a8e99db4ab9083ff36881c223 
  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionEntry.java bedbf8148556360ae80672b836ba40fafd47df01 

Diff: https://reviews.apache.org/r/47201/diff/


Testing
-------

precheckin


Thanks,

Darrel Schneider


Re: Review Request 47201: removed @Retained from getValueInVM since its result is never off-heap

Posted by Sai Boorlagadda <sb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47201/#review132674
-----------------------------------------------------------


Ship it!




Ship It!

- Sai Boorlagadda


On May 10, 2016, 11:40 p.m., Darrel Schneider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47201/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 11:40 p.m.)
> 
> 
> Review request for geode, Eric Shu, Ken Howe, and Sai Boorlagadda.
> 
> 
> Bugs: GEODE-1289
>     https://issues.apache.org/jira/browse/GEODE-1289
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> removed @Retained from getValueInVM since its result is never off-heap
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/AbstractIndex.java 96e83b26e00f701e86c900ed44664e93f826e0c9 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java 46a851dfbae3641925b1529f2da562d9feca57e4 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java 75a1e3270793824a8e99db4ab9083ff36881c223 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionEntry.java bedbf8148556360ae80672b836ba40fafd47df01 
> 
> Diff: https://reviews.apache.org/r/47201/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>