You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/01/29 01:42:41 UTC
Re: Review Request 40731: Added a test case for floating point
precision of resource allocation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 12:42 a.m.)
Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil Conway.
Summary (updated)
-----------------
Added a test case for floating point precision of resource allocation.
Bugs: MESOS-3552
https://issues.apache.org/jira/browse/MESOS-3552
Repository: mesos
Description (updated)
-------
Added a test case for floating point precision of resource allocation. This patch is based on the commit submitted by : Mandeep (@mchadha) https://reviews.apache.org/r/39056/
Diffs (updated)
-----
CHANGELOG 82c1be60deca0eba0bcaff0331662df1b26690ef
bootstrap d0dd491e99b1e60dfe5c1ada3388e78673112b96
bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4
docs/high-availability-framework-guide.md 3d429d85edce695f608320cab05cdafdafa4a42e
docs/release-guide.md 3a6b7d984222cc20c2d3cd547f74c802b3a24ce9
include/mesos/resources.hpp 6bfac2e7e8799e74d87c7570fc5eef320ba76eb1
include/mesos/slave/isolator.hpp 4be8c2bb409052e2e07138483408209384f41e23
include/mesos/v1/resources.hpp 5a88c0756db2ea8db0f5df7ea3019b511ea135af
src/CMakeLists.txt 93caf000f39bbb71a17d9876689afb50cf637e44
src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1
src/common/command_utils.hpp bfab34571dd37980d9f99585e506eb015b499e28
src/common/command_utils.cpp e9d782127f948e165f55d03a2b1bf47946cc7f4e
src/common/type_utils.cpp 42e3061818c49c6b62d4fee2479db078dfe0fc89
src/java/MESOS-MAVEN-README 2812fb14718246371abdb0ff56d0761654c6ebe2
src/master/allocator/mesos/hierarchical.cpp 1a07d69016407e5aad2209586da37fecbcddb765
src/master/allocator/sorter/drf/sorter.cpp db47d640e36c0302d7c6254a9c58caa878feac01
src/master/http.cpp 54264f6e4ad5802ce92eaec7dc33164afe779da5
src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83
src/slave/container_loggers/lib_logrotate.cpp 8d2f89503cd8ace1971933006a46ed4d3936ff8e
src/slave/containerizer/mesos/isolator.hpp bacd86af42d16cb7c9b6622dfb298dcaa7007b75
src/slave/containerizer/mesos/isolator.cpp 253ff3cea8aff3e7a3051fb5a763cc081f455f18
src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp ddc1bf0939e5e8995e6f34fe7b8509b51704f63e
src/slave/containerizer/mesos/isolators/posix/disk.hpp 3998251248ecef2d174f0ea68e0493d09b012952
src/slave/containerizer/mesos/isolators/posix/disk.cpp fd9b3abfe2c502c69ba7b2f0b2015fe90888d5bc
src/slave/resource_estimators/fixed.cpp c858a48bc137185d1e1e24a20f6b75b0dd7912ff
src/tests/common/command_utils_tests.cpp 938f3995aacf74bac28ae11040de292aa328f1e5
src/tests/container_logger_tests.cpp e161fd671972d365a25a5f2e238e11815e574164
src/tests/containerizer/isolator_tests.cpp 8d101df957fd36adac388310eddba2db1f98c029
src/tests/disk_quota_tests.cpp 413e562026a4fc9779f616e921ae2fa2ca51e012
src/tests/master_tests.cpp ce6ce25a03cdb0883612fe40b20996ec2e50de40
src/tests/reservation_tests.cpp d0c88560a5618ebec39fc4e0539ddb2d9ca554a2
src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a
src/tests/status_update_manager_tests.cpp 7bedd499a241a61938069381e0d4fafa4b8f96db
src/v1/mesos.cpp 21b14cf7050270facab1ba2b844c3fde664665a4
src/v1/resources.cpp be4a5d153e9313cb71a6e85d1ed25a358537f2b7
support/gitignore
Diff: https://reviews.apache.org/r/40731/diff/
Testing
-------
Ran make check after adding Mandeep's test case to the GTEST framework.
Thanks,
Avinash sridharan
Re: Review Request 40731: Added a test case for floating point
precision of resource allocation.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/#review117593
-----------------------------------------------------------
Ship it!
Ship It!
- Bernd Mathiske
On Jan. 28, 2016, 4:45 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40731/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 4:45 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil Conway.
>
>
> Bugs: MESOS-3552
> https://issues.apache.org/jira/browse/MESOS-3552
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test case for floating point precision of resource allocation. This patch is based on the commit submitted by : Mandeep (@mchadha) https://reviews.apache.org/r/39056/
>
>
> Diffs
> -----
>
> src/tests/reservation_tests.cpp d0c88560a5618ebec39fc4e0539ddb2d9ca554a2
>
> Diff: https://reviews.apache.org/r/40731/diff/
>
>
> Testing
> -------
>
> Ran make check after adding Mandeep's test case to the GTEST framework.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 40731: Added a test case for floating point
precision of resource allocation.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/#review116868
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40731]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 29, 2016, 12:45 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40731/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 12:45 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil Conway.
>
>
> Bugs: MESOS-3552
> https://issues.apache.org/jira/browse/MESOS-3552
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test case for floating point precision of resource allocation. This patch is based on the commit submitted by : Mandeep (@mchadha) https://reviews.apache.org/r/39056/
>
>
> Diffs
> -----
>
> src/tests/reservation_tests.cpp d0c88560a5618ebec39fc4e0539ddb2d9ca554a2
>
> Diff: https://reviews.apache.org/r/40731/diff/
>
>
> Testing
> -------
>
> Ran make check after adding Mandeep's test case to the GTEST framework.
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 40731: Added a test case for floating point
precision of resource allocation.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40731/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 12:45 a.m.)
Review request for mesos, Bernd Mathiske, Klaus Ma, Mandeep Chadha, and Neil Conway.
Bugs: MESOS-3552
https://issues.apache.org/jira/browse/MESOS-3552
Repository: mesos
Description
-------
Added a test case for floating point precision of resource allocation. This patch is based on the commit submitted by : Mandeep (@mchadha) https://reviews.apache.org/r/39056/
Diffs (updated)
-----
src/tests/reservation_tests.cpp d0c88560a5618ebec39fc4e0539ddb2d9ca554a2
Diff: https://reviews.apache.org/r/40731/diff/
Testing
-------
Ran make check after adding Mandeep's test case to the GTEST framework.
Thanks,
Avinash sridharan