You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/28 12:23:02 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request, #16268: [feature][cli] Pulsar shell - non interactive mode - part 2
nicoloboschi opened a new pull request, #16268:
URL: https://github.com/apache/pulsar/pull/16268
Master Issue: #16250
### Motivation
See the PIP for the full context.
### Modifications
* Added new parameter `-f/--filename` that accepts a file to run. The file must be a simple text file with a list of commands separated by newline char.
* Added new parameter `-e/--exit-on-error` to exit in case of a failure of a command.
* Added new parameter `-` which means the shell will read the standard input to process commands to run
* The non-interactive mode will print the progress of the processing in a fancy way. You can disable it with `-np/--no-progress`
Usage examples:
```
# interactive mode
./bin/pulsar-shell
# file mode
./bin/pulsar-shell -f path/to/my-file
# pipe mode
cat path/to/my-file | ./bin/pulsar-shell -
echo "admin tenants create ten\nadmin namespaces create ten/ns" | ./bin/pulsar-shell -
wget https://raw.githubusercontent.com/nicoloboschi/pulsar/e3f2fe8560c65e36ff699f7dadc803ce69794541/pulsar-client-tools/src/test/resources/test-shell-file | ./bin/pulsar-shell -
```
- [x] `doc-required`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on a diff in pull request #16268: [feature][cli] Pulsar shell - non interactive mode - part 3
Posted by GitBox <gi...@apache.org>.
eolivelli commented on code in PR #16268:
URL: https://github.com/apache/pulsar/pull/16268#discussion_r923250005
##########
bin/pulsar-admin-common.sh:
##########
@@ -56,18 +56,18 @@ fi
add_maven_deps_to_classpath() {
MVN="mvn"
if [ "$MAVEN_HOME" != "" ]; then
- MVN=${MAVEN_HOME}/bin/mvn
+ MVN=${MAVEN_HOME}/bin/mvn
Review Comment:
is this intended ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi merged pull request #16268: [feature][cli] Pulsar shell - non interactive mode - part 3
Posted by GitBox <gi...@apache.org>.
nicoloboschi merged PR #16268:
URL: https://github.com/apache/pulsar/pull/16268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org