[GitHub] [hadoop] bgaborg commented on a change in pull request #802: HADOOP-16279. S3Guard: Implement time-based (TTL) expiry for entries …

[GitBox <gi...@apache.org>]

bgaborg commented on a change in pull request #802: HADOOP-16279. S3Guard: Implement time-based (TTL) expiry for entries …
URL: https://github.com/apache/hadoop/pull/802#discussion_r289859396
 
 

 ##########
 File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/S3Guard.java
 ##########
 @@ -549,10 +539,43 @@ public static void putWithTtl(MetadataStore ms, DirListingMetadata dirMeta,
     ms.put(dirMeta);
   }
 
+  public static void putWithTtl(MetadataStore ms, PathMetadata fileMeta,
+      ITtlTimeProvider timeProvider) throws IOException {
+    fileMeta.setLastUpdated(timeProvider.getNow());
+    ms.put(fileMeta);
+  }
+
+  public static void putWithTtl(MetadataStore ms,
+      Collection<PathMetadata> fileMetas, ITtlTimeProvider timeProvider)
+      throws IOException {
+    fileMetas.forEach(
+        fileMeta -> fileMeta.setLastUpdated(timeProvider.getNow())
+    );
+    ms.put(fileMetas);
+  }
+
+  public static PathMetadata getWithTtl(MetadataStore ms, Path path,
+      ITtlTimeProvider timeProvider) throws IOException {
+    long ttl = timeProvider.getMetadataTtl();
+
+    final PathMetadata pathMetadata = ms.get(path);
+
+    if(pathMetadata != null) {
+      if(!pathMetadata.isExpired(ttl, timeProvider.getNow())) {
+        return pathMetadata;
+      } else {
+        LOG.debug("PathMetadata TTl for {} is expired in metadata store.");
 
 Review comment:
   thanks fixed. I'll resolve the outdated comments

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org