You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Ryan Baxter <rb...@gmail.com> on 2012/01/07 19:56:37 UTC

Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/#review4240
-----------------------------------------------------------



/trunk/content/samplecontainer/examples/commoncontainer/index.html
<https://reviews.apache.org/r/3165/#comment9592>

    You probably want to wrap these label - input element combinations in divs or but breaks inbetween them.  If the screen is wide enough the labels end up not being on the same line as the input fields.


- Ryan


On 2011-12-21 17:24:41, Matt Marum wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3165/
> -----------------------------------------------------------
> 
> (Updated 2011-12-21 17:24:41)
> 
> 
> Review request for shindig.
> 
> 
> Summary
> -------
> 
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> 
> This has makes quickly testing EE gadgets much easier.
> 
> 
> This addresses bug SHINDIG-1675.
>     https://issues.apache.org/jira/browse/SHINDIG-1675
> 
> 
> Diffs
> -----
> 
>   /trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1220905 
>   /trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1220905 
>   /trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1220905 
>   /trunk/content/samplecontainer/examples/commoncontainer/index.html 1220905 
> 
> Diff: https://reviews.apache.org/r/3165/diff
> 
> 
> Testing
> -------
> 
> Tested locally with some EE gadgets I've been building.  Andy Smith has used it too.  There are no automated tests for the sample containers.
> 
> 
> Thanks,
> 
> Matt
> 
>