[jira] [Commented] (OOZIE-1599) Cache the list of available timezones from the admin servlet

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397174#comment-15397174 ] 

Hadoop QA commented on OOZIE-1599:
----------------------------------

Testing JIRA OOZIE-1599

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:red}-1{color} the patch contains 1 line(s) with trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:red}-1 COMPILE{color}
.    {color:red}-1{color} HEAD does not compile
.    {color:red}-1{color} patch does not compile
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 1791
.    Tests failed: 7
.    Tests errors: 2

.    The patch failed the following testcases:

.      testActionKillCommandActionNumbers(org.apache.oozie.command.coord.TestCoordActionsKillXCommand)
.      testRecovery(org.apache.oozie.action.hadoop.TestJavaActionExecutor)
.      testMain(org.apache.oozie.action.hadoop.TestHiveMain)
.      testPigScript(org.apache.oozie.action.hadoop.TestPigMain)
.      testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain)
.      testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)
.      testPigScript(org.apache.oozie.action.hadoop.TestPigMainWithOldAPI)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/3129/

> Cache the list of available timezones from the admin servlet
> ------------------------------------------------------------
>
>                 Key: OOZIE-1599
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1599
>             Project: Oozie
>          Issue Type: Improvement
>    Affects Versions: trunk
>            Reporter: Robert Kanter
>            Assignee: Sreepathi Prasanna
>              Labels: newbie
>             Fix For: trunk
>
>         Attachments: OOZIE-1599.patch.1
>
>
> The admin servlet has a call that returns a list of available timezones.  On startup, it prepares a list of GMT offsets (e.g. "GMT-12:00", "GMT-11:00", etc), which is only generated once.  But the rest of the timezones (e.g. "America/Los_Angeles", etc) are processed from {{TimeZone}} every time the admin servlet is asked for the list.  
> We should refactor this to generate/process the entire list either the first time its called or at startup and then simply return the {{JSONArray}} when the admin servlet is asked for the list.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)