[GitHub] [hudi] vinothchandar commented on a diff in pull request #6154: [HUDI-4434] Disable EmrFS file metadata caching and EMR Spark's data prefetcher feature

[GitBox <gi...@apache.org>]

vinothchandar commented on code in PR #6154:
URL: https://github.com/apache/hudi/pull/6154#discussion_r928788187


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DefaultSource.scala:
##########
@@ -56,6 +56,9 @@ class DefaultSource extends RelationProvider
       // Enable "passPartitionByAsOptions" to support "write.partitionBy(...)"
       spark.conf.set("spark.sql.legacy.sources.write.passPartitionByAsOptions", "true")
     }
+    // Revisit EMR Spark and EMRFS incompatibilities, for now disable
+    spark.conf.set("spark.sql.dataPrefetch.enabled", "false")
+    spark.sparkContext.hadoopConfiguration.set("fs.s3.metadata.cache.expiration.seconds", "0")

Review Comment:
   Instead of hard-coding to false, shall we also allow for override using --conf . I wonder if it's better todo this in the EMR Huds configs, rather than code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org