[GitHub] [tvm] Lunderberg commented on a diff in pull request #14475: [pytest] Don't return values from test_* functions

["Lunderberg (via GitHub)" <gi...@apache.org>]

Lunderberg commented on code in PR #14475:
URL: https://github.com/apache/tvm/pull/14475#discussion_r1157421670


##########
tests/python/contrib/test_hexagon/test_maxpool2d_blocked.py:
##########
@@ -151,7 +151,7 @@ def test_maxpool(self, shape_nhwc, window_size, stride, pad, dtype, target):
             padding=(pad, pad, pad, pad),
             dtype=dtype,
         )
-        return output, ref_output
+        assert all([output is not None, ref_output is not None])

Review Comment:
   If the assert is causing spurious unit test failures, it can be removed.  The test is to ensure that no exceptions are through while lowering/building, and no further assert is required.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org