You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/10/22 09:55:35 UTC
[GitHub] [apisix] bisakhmondal opened a new pull request #5316: ci: test framework requires grpcurl in centos7 ci
bisakhmondal opened a new pull request #5316:
URL: https://github.com/apache/apisix/pull/5316
### What this PR does / why we need it:
1. Install commands of grpcurl in centos 7 CI
2. End user installation documentation
3. Update in existing way on grpcurl installation.
[The existing api7 checkout is not maintained for a long time, so it's better to use go install the official package.]
PS: Go will be required in the next PR's on the CI setup steps as we will put the grpc_example_server repo as a git submodule. So please don't freak out : )
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on a change in pull request #5316: ci: test framework requires grpcurl in centos7 ci
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on a change in pull request #5316:
URL: https://github.com/apache/apisix/pull/5316#discussion_r735108780
##########
File path: ci/centos7-ci.sh
##########
@@ -57,6 +57,10 @@ install_dependencies() {
# wait for grpc_server_example to fully start
sleep 3
+ # installing grpcurl
+ wget https://github.com/fullstorydev/grpcurl/releases/download/v1.8.5/grpcurl_1.8.5_linux_x86_64.tar.gz
+ tar -xvf grpcurl_1.8.5_linux_x86_64.tar.gz -C /usr/local/bin
Review comment:
Yeah, makes sense!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5316: ci: test framework requires grpcurl in centos7 ci
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #5316:
URL: https://github.com/apache/apisix/pull/5316#issuecomment-950579669
@bisakhmondal
Now you can do the rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on a change in pull request #5316: ci: test framework requires grpcurl in centos7 ci
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on a change in pull request #5316:
URL: https://github.com/apache/apisix/pull/5316#discussion_r734429423
##########
File path: .github/workflows/build.yml
##########
@@ -38,6 +38,11 @@ jobs:
with:
submodules: recursive
+ - name: Setup Go
+ uses: actions/setup-go@v2.1.4
+ with:
+ go-version: "^1.13"
Review comment:
Will keep in mind. Not required for this CL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5316: ci: test framework requires grpcurl in centos7 ci
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on a change in pull request #5316:
URL: https://github.com/apache/apisix/pull/5316#discussion_r735015197
##########
File path: ci/centos7-ci.sh
##########
@@ -57,6 +57,10 @@ install_dependencies() {
# wait for grpc_server_example to fully start
sleep 3
+ # installing grpcurl
+ wget https://github.com/fullstorydev/grpcurl/releases/download/v1.8.5/grpcurl_1.8.5_linux_x86_64.tar.gz
+ tar -xvf grpcurl_1.8.5_linux_x86_64.tar.gz -C /usr/local/bin
Review comment:
Can we put it into `ci/common.sh` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on a change in pull request #5316: ci: test framework requires grpcurl in centos7 ci
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on a change in pull request #5316:
URL: https://github.com/apache/apisix/pull/5316#discussion_r735147417
##########
File path: ci/centos7-ci.sh
##########
@@ -57,6 +57,10 @@ install_dependencies() {
# wait for grpc_server_example to fully start
sleep 3
+ # installing grpcurl
+ wget https://github.com/fullstorydev/grpcurl/releases/download/v1.8.5/grpcurl_1.8.5_linux_x86_64.tar.gz
+ tar -xvf grpcurl_1.8.5_linux_x86_64.tar.gz -C /usr/local/bin
Review comment:
Sorry just now I realized, the common script (this is being sourced not executed) has been used for exporting PATH variables and a ledger to store version numbers as a single source. I think let's keep it that way only, a logical separation. Let the CI of different os, execute the particular script meant for that os. A future proof solution, haha : )
Let me know what do you think, Thanks!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5316: ci: test framework requires grpcurl in centos7 ci
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on a change in pull request #5316:
URL: https://github.com/apache/apisix/pull/5316#discussion_r735159892
##########
File path: ci/centos7-ci.sh
##########
@@ -57,6 +57,10 @@ install_dependencies() {
# wait for grpc_server_example to fully start
sleep 3
+ # installing grpcurl
+ wget https://github.com/fullstorydev/grpcurl/releases/download/v1.8.5/grpcurl_1.8.5_linux_x86_64.tar.gz
+ tar -xvf grpcurl_1.8.5_linux_x86_64.tar.gz -C /usr/local/bin
Review comment:
Can we put it in `ci/common.sh` as a func `install_grpcurl`, then let the CI workflow of different OS choose whether to call it or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5316: ci: test framework requires grpcurl in centos7 ci
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5316:
URL: https://github.com/apache/apisix/pull/5316#discussion_r734408214
##########
File path: docs/zh/latest/grpc-proxy.md
##########
@@ -66,6 +66,8 @@ grpcurl -insecure -import-path /pathtoprotos -proto helloworld.proto \
}
```
+> grpcurl 是一个 CLI 工具，类似于 curl，充当 gRPC 客户端并让您与 gRPC 服务器进行交互。安装请查看官方 [文件](https://github.com/fullstorydev/grpcurl#installation)
Review comment:
```suggestion
> grpcurl 是一个 CLI 工具，类似于 curl，充当 gRPC 客户端并让您与 gRPC 服务器进行交互。安装方式请查看官方[文档](https://github.com/fullstorydev/grpcurl#installation)
```
##########
File path: .github/workflows/build.yml
##########
@@ -38,6 +38,11 @@ jobs:
with:
submodules: recursive
+ - name: Setup Go
+ uses: actions/setup-go@v2.1.4
+ with:
+ go-version: "^1.13"
Review comment:
Better to specify a fix version
##########
File path: ci/centos7-ci.sh
##########
@@ -57,6 +57,9 @@ install_dependencies() {
# wait for grpc_server_example to fully start
sleep 3
+ # installing grpcurl
+ go install github.com/fullstorydev/grpcurl/cmd/grpcurl@latest
Review comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5316: ci: test framework requires grpcurl in centos7 ci
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5316:
URL: https://github.com/apache/apisix/pull/5316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5316: ci: test framework requires grpcurl in centos7 ci
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on a change in pull request #5316:
URL: https://github.com/apache/apisix/pull/5316#discussion_r735159871
##########
File path: ci/centos7-ci.sh
##########
@@ -57,6 +57,10 @@ install_dependencies() {
# wait for grpc_server_example to fully start
sleep 3
+ # installing grpcurl
+ wget https://github.com/fullstorydev/grpcurl/releases/download/v1.8.5/grpcurl_1.8.5_linux_x86_64.tar.gz
+ tar -xvf grpcurl_1.8.5_linux_x86_64.tar.gz -C /usr/local/bin
Review comment:
May we put it in `ci/common.sh` as a func `install_grpcurl`, then let the CI workflow of different OS chose to call it or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on a change in pull request #5316: ci: test framework requires grpcurl in centos7 ci
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on a change in pull request #5316:
URL: https://github.com/apache/apisix/pull/5316#discussion_r734429213
##########
File path: ci/centos7-ci.sh
##########
@@ -57,6 +57,9 @@ install_dependencies() {
# wait for grpc_server_example to fully start
sleep 3
+ # installing grpcurl
+ go install github.com/fullstorydev/grpcurl/cmd/grpcurl@latest
Review comment:
Thanks for pointing it out. Using wget to pull v1.8.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on a change in pull request #5316: ci: test framework requires grpcurl in centos7 ci
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on a change in pull request #5316:
URL: https://github.com/apache/apisix/pull/5316#discussion_r735168654
##########
File path: ci/centos7-ci.sh
##########
@@ -57,6 +57,10 @@ install_dependencies() {
# wait for grpc_server_example to fully start
sleep 3
+ # installing grpcurl
+ wget https://github.com/fullstorydev/grpcurl/releases/download/v1.8.5/grpcurl_1.8.5_linux_x86_64.tar.gz
+ tar -xvf grpcurl_1.8.5_linux_x86_64.tar.gz -C /usr/local/bin
Review comment:
Okay, fine then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org