You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Josh Elser <el...@apache.org> on 2017/04/25 16:13:39 UTC
[DISCUSS] Merge HBASE-16961 (Space Quotas) into master
Hi folks,
Here's a formal thread for discussion on merging the space quota feature
(presently in the branch HBASE-16961[1]) into master. The tl;dr on the
feature is that this extends the RPC quota feature to include
configurable limits on the size of tables and namespaces. Please check
the archives for earlier discussion on design if you'd like a more
in-depth recap.
So far, our Ted and Vlad have devoted cycles to reviewing the code and
have given their +1's (Ted along the way, Vlad after the fact). Thanks
to both of them.
Outstanding, I have to commit the feedback from Vlad (due to PreCommit
being hosed -- INFRA-13985), and rebase on top of master once more
(these have been rather clean/easy to do). Since both of these tasks are
pretty minor, I figured we can start the discussion now
Thoughts/Opinions? Objections? Approvals? Cat-photos?
- Josh
[1] https://issues.apache.org/jira/browse/HBASE-16961
Re: [DISCUSS] Merge HBASE-16961 (Space Quotas) into master
Posted by Josh Elser <el...@apache.org>.
@Stack ok, wasn't sure if you had asked for the info because you were
actively looking at it or not.
@Andrew Cool beans. Code review at any point is appreciated. We can
definitely continue to clean things up.
With that said, let me just start a VOTE now so I don't forget to do it
Monday morning ;)
Andrew Purtell wrote:
> I'll try to review beyond page two of the diffs soon Josh, for specific
> code issues (if any). So far I've only seen the one, which you called out,
> about a potential bottleneck executing admin actions if wanting to apply a
> lot of changes at once.
>
> In terms of high level design and the ops model, I'd be good with a merge.
>
> On Fri, May 5, 2017 at 1:43 PM, Stack<st...@duboce.net> wrote:
>
>> On Fri, May 5, 2017 at 9:12 AM, Josh Elser<el...@apache.org> wrote:
>>
>>> Just an update: Andrew P provided some great feedback which I've finally
>>> got all merged into the feature branch [1][2][3]. Many thanks again -- it
>>> was some really nice feedback.
>>>
>>> @Stack: do you have review/thoughts pending?
>>>
>>>
>> I'm on something else Josh. Nice you got feedback elsewhere.
>> Thanks,
>> St.Ack
>>
>>
>>
>>> Anyone else maybe thinking in the back of their head, but haven't said
>>> anything yet?
>>>
>>> I would like to keep pushing on this, but I also don't want to call a
>>> premature vote to merge.
>>>
>>> - Josh
>>>
>>> [1] https://issues.apache.org/jira/browse/HBASE-17977
>>> [2] https://issues.apache.org/jira/browse/HBASE-17978
>>> [3] https://issues.apache.org/jira/browse/HBASE-17981
>>>
>>>
>>> Josh Elser wrote:
>>>
>>>> I published a current copy of the book -- check out the new chapter on
>>>> the feature to start [1]. Then, to walk through using the feature, I'd
>>>> take a look at this comment[2] which has a little script to create some
>>>> tables/quotas and tries to step you a (contrived) example workflow.
>>>>
>>>> LMK if you have more specific questions. Happy to answer directly or
>>>> point you to the code to let you answer it yourself :)
>>>>
>>>> [1] https://people.apache.org/~elserj/hbase/quotas/book.html#
>> space-quotas
>>>> [2]
>>>> https://issues.apache.org/jira/browse/HBASE-16961?focusedCom
>>>> mentId=15941163&page=com.atlassian.jira.plugin.system.
>>>> issuetabpanels:comment-tabpanel#comment-15941163
>>>>
>>>>
>>>> Stack wrote:
>>>>
>>>>> Sounds like an excellent idea to me. If I were to take a tour over the
>>>>> quotas feature, how would you direct my perambulations Josh?
>>>>> Thanks,
>>>>> St.Ack
>>>>>
>>>>> On Tue, Apr 25, 2017 at 9:13 AM, Josh Elser<el...@apache.org> wrote:
>>>>>
>>>>> Hi folks,
>>>>>> Here's a formal thread for discussion on merging the space quota
>> feature
>>>>>> (presently in the branch HBASE-16961[1]) into master. The tl;dr on the
>>>>>> feature is that this extends the RPC quota feature to include
>>>>>> configurable
>>>>>> limits on the size of tables and namespaces. Please check the
>>>>>> archives for
>>>>>> earlier discussion on design if you'd like a more in-depth recap.
>>>>>>
>>>>>> So far, our Ted and Vlad have devoted cycles to reviewing the code and
>>>>>> have given their +1's (Ted along the way, Vlad after the fact).
>>>>>> Thanks to
>>>>>> both of them.
>>>>>>
>>>>>> Outstanding, I have to commit the feedback from Vlad (due to PreCommit
>>>>>> being hosed -- INFRA-13985), and rebase on top of master once more
>>>>>> (these
>>>>>> have been rather clean/easy to do). Since both of these tasks are
>> pretty
>>>>>> minor, I figured we can start the discussion now
>>>>>>
>>>>>> Thoughts/Opinions? Objections? Approvals? Cat-photos?
>>>>>>
>>>>>> - Josh
>>>>>>
>>>>>> [1] https://issues.apache.org/jira/browse/HBASE-16961
>>>>>>
>>>>>>
>
>
>
Re: [DISCUSS] Merge HBASE-16961 (Space Quotas) into master
Posted by Andrew Purtell <ap...@apache.org>.
I'll try to review beyond page two of the diffs soon Josh, for specific
code issues (if any). So far I've only seen the one, which you called out,
about a potential bottleneck executing admin actions if wanting to apply a
lot of changes at once.
In terms of high level design and the ops model, I'd be good with a merge.
On Fri, May 5, 2017 at 1:43 PM, Stack <st...@duboce.net> wrote:
> On Fri, May 5, 2017 at 9:12 AM, Josh Elser <el...@apache.org> wrote:
>
> > Just an update: Andrew P provided some great feedback which I've finally
> > got all merged into the feature branch [1][2][3]. Many thanks again -- it
> > was some really nice feedback.
> >
> > @Stack: do you have review/thoughts pending?
> >
> >
> I'm on something else Josh. Nice you got feedback elsewhere.
> Thanks,
> St.Ack
>
>
>
> > Anyone else maybe thinking in the back of their head, but haven't said
> > anything yet?
> >
> > I would like to keep pushing on this, but I also don't want to call a
> > premature vote to merge.
> >
> > - Josh
> >
> > [1] https://issues.apache.org/jira/browse/HBASE-17977
> > [2] https://issues.apache.org/jira/browse/HBASE-17978
> > [3] https://issues.apache.org/jira/browse/HBASE-17981
> >
> >
> > Josh Elser wrote:
> >
> >> I published a current copy of the book -- check out the new chapter on
> >> the feature to start [1]. Then, to walk through using the feature, I'd
> >> take a look at this comment[2] which has a little script to create some
> >> tables/quotas and tries to step you a (contrived) example workflow.
> >>
> >> LMK if you have more specific questions. Happy to answer directly or
> >> point you to the code to let you answer it yourself :)
> >>
> >> [1] https://people.apache.org/~elserj/hbase/quotas/book.html#
> space-quotas
> >> [2]
> >> https://issues.apache.org/jira/browse/HBASE-16961?focusedCom
> >> mentId=15941163&page=com.atlassian.jira.plugin.system.
> >> issuetabpanels:comment-tabpanel#comment-15941163
> >>
> >>
> >> Stack wrote:
> >>
> >>> Sounds like an excellent idea to me. If I were to take a tour over the
> >>> quotas feature, how would you direct my perambulations Josh?
> >>> Thanks,
> >>> St.Ack
> >>>
> >>> On Tue, Apr 25, 2017 at 9:13 AM, Josh Elser<el...@apache.org> wrote:
> >>>
> >>> Hi folks,
> >>>>
> >>>> Here's a formal thread for discussion on merging the space quota
> feature
> >>>> (presently in the branch HBASE-16961[1]) into master. The tl;dr on the
> >>>> feature is that this extends the RPC quota feature to include
> >>>> configurable
> >>>> limits on the size of tables and namespaces. Please check the
> >>>> archives for
> >>>> earlier discussion on design if you'd like a more in-depth recap.
> >>>>
> >>>> So far, our Ted and Vlad have devoted cycles to reviewing the code and
> >>>> have given their +1's (Ted along the way, Vlad after the fact).
> >>>> Thanks to
> >>>> both of them.
> >>>>
> >>>> Outstanding, I have to commit the feedback from Vlad (due to PreCommit
> >>>> being hosed -- INFRA-13985), and rebase on top of master once more
> >>>> (these
> >>>> have been rather clean/easy to do). Since both of these tasks are
> pretty
> >>>> minor, I figured we can start the discussion now
> >>>>
> >>>> Thoughts/Opinions? Objections? Approvals? Cat-photos?
> >>>>
> >>>> - Josh
> >>>>
> >>>> [1] https://issues.apache.org/jira/browse/HBASE-16961
> >>>>
> >>>>
> >>>
>
--
Best regards,
- Andy
If you are given a choice, you believe you have acted freely. - Raymond
Teller (via Peter Watts)
Re: [DISCUSS] Merge HBASE-16961 (Space Quotas) into master
Posted by Stack <st...@duboce.net>.
On Fri, May 5, 2017 at 9:12 AM, Josh Elser <el...@apache.org> wrote:
> Just an update: Andrew P provided some great feedback which I've finally
> got all merged into the feature branch [1][2][3]. Many thanks again -- it
> was some really nice feedback.
>
> @Stack: do you have review/thoughts pending?
>
>
I'm on something else Josh. Nice you got feedback elsewhere.
Thanks,
St.Ack
> Anyone else maybe thinking in the back of their head, but haven't said
> anything yet?
>
> I would like to keep pushing on this, but I also don't want to call a
> premature vote to merge.
>
> - Josh
>
> [1] https://issues.apache.org/jira/browse/HBASE-17977
> [2] https://issues.apache.org/jira/browse/HBASE-17978
> [3] https://issues.apache.org/jira/browse/HBASE-17981
>
>
> Josh Elser wrote:
>
>> I published a current copy of the book -- check out the new chapter on
>> the feature to start [1]. Then, to walk through using the feature, I'd
>> take a look at this comment[2] which has a little script to create some
>> tables/quotas and tries to step you a (contrived) example workflow.
>>
>> LMK if you have more specific questions. Happy to answer directly or
>> point you to the code to let you answer it yourself :)
>>
>> [1] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas
>> [2]
>> https://issues.apache.org/jira/browse/HBASE-16961?focusedCom
>> mentId=15941163&page=com.atlassian.jira.plugin.system.
>> issuetabpanels:comment-tabpanel#comment-15941163
>>
>>
>> Stack wrote:
>>
>>> Sounds like an excellent idea to me. If I were to take a tour over the
>>> quotas feature, how would you direct my perambulations Josh?
>>> Thanks,
>>> St.Ack
>>>
>>> On Tue, Apr 25, 2017 at 9:13 AM, Josh Elser<el...@apache.org> wrote:
>>>
>>> Hi folks,
>>>>
>>>> Here's a formal thread for discussion on merging the space quota feature
>>>> (presently in the branch HBASE-16961[1]) into master. The tl;dr on the
>>>> feature is that this extends the RPC quota feature to include
>>>> configurable
>>>> limits on the size of tables and namespaces. Please check the
>>>> archives for
>>>> earlier discussion on design if you'd like a more in-depth recap.
>>>>
>>>> So far, our Ted and Vlad have devoted cycles to reviewing the code and
>>>> have given their +1's (Ted along the way, Vlad after the fact).
>>>> Thanks to
>>>> both of them.
>>>>
>>>> Outstanding, I have to commit the feedback from Vlad (due to PreCommit
>>>> being hosed -- INFRA-13985), and rebase on top of master once more
>>>> (these
>>>> have been rather clean/easy to do). Since both of these tasks are pretty
>>>> minor, I figured we can start the discussion now
>>>>
>>>> Thoughts/Opinions? Objections? Approvals? Cat-photos?
>>>>
>>>> - Josh
>>>>
>>>> [1] https://issues.apache.org/jira/browse/HBASE-16961
>>>>
>>>>
>>>
Re: [DISCUSS] Merge HBASE-16961 (Space Quotas) into master
Posted by Josh Elser <el...@apache.org>.
Just an update: Andrew P provided some great feedback which I've finally
got all merged into the feature branch [1][2][3]. Many thanks again --
it was some really nice feedback.
@Stack: do you have review/thoughts pending?
Anyone else maybe thinking in the back of their head, but haven't said
anything yet?
I would like to keep pushing on this, but I also don't want to call a
premature vote to merge.
- Josh
[1] https://issues.apache.org/jira/browse/HBASE-17977
[2] https://issues.apache.org/jira/browse/HBASE-17978
[3] https://issues.apache.org/jira/browse/HBASE-17981
Josh Elser wrote:
> I published a current copy of the book -- check out the new chapter on
> the feature to start [1]. Then, to walk through using the feature, I'd
> take a look at this comment[2] which has a little script to create some
> tables/quotas and tries to step you a (contrived) example workflow.
>
> LMK if you have more specific questions. Happy to answer directly or
> point you to the code to let you answer it yourself :)
>
> [1] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas
> [2]
> https://issues.apache.org/jira/browse/HBASE-16961?focusedCommentId=15941163&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15941163
>
>
> Stack wrote:
>> Sounds like an excellent idea to me. If I were to take a tour over the
>> quotas feature, how would you direct my perambulations Josh?
>> Thanks,
>> St.Ack
>>
>> On Tue, Apr 25, 2017 at 9:13 AM, Josh Elser<el...@apache.org> wrote:
>>
>>> Hi folks,
>>>
>>> Here's a formal thread for discussion on merging the space quota feature
>>> (presently in the branch HBASE-16961[1]) into master. The tl;dr on the
>>> feature is that this extends the RPC quota feature to include
>>> configurable
>>> limits on the size of tables and namespaces. Please check the
>>> archives for
>>> earlier discussion on design if you'd like a more in-depth recap.
>>>
>>> So far, our Ted and Vlad have devoted cycles to reviewing the code and
>>> have given their +1's (Ted along the way, Vlad after the fact).
>>> Thanks to
>>> both of them.
>>>
>>> Outstanding, I have to commit the feedback from Vlad (due to PreCommit
>>> being hosed -- INFRA-13985), and rebase on top of master once more
>>> (these
>>> have been rather clean/easy to do). Since both of these tasks are pretty
>>> minor, I figured we can start the discussion now
>>>
>>> Thoughts/Opinions? Objections? Approvals? Cat-photos?
>>>
>>> - Josh
>>>
>>> [1] https://issues.apache.org/jira/browse/HBASE-16961
>>>
>>
Re: [DISCUSS] Merge HBASE-16961 (Space Quotas) into master
Posted by Josh Elser <el...@apache.org>.
I published a current copy of the book -- check out the new chapter on
the feature to start [1]. Then, to walk through using the feature, I'd
take a look at this comment[2] which has a little script to create some
tables/quotas and tries to step you a (contrived) example workflow.
LMK if you have more specific questions. Happy to answer directly or
point you to the code to let you answer it yourself :)
[1] https://people.apache.org/~elserj/hbase/quotas/book.html#space-quotas
[2]
https://issues.apache.org/jira/browse/HBASE-16961?focusedCommentId=15941163&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15941163
Stack wrote:
> Sounds like an excellent idea to me. If I were to take a tour over the
> quotas feature, how would you direct my perambulations Josh?
> Thanks,
> St.Ack
>
> On Tue, Apr 25, 2017 at 9:13 AM, Josh Elser<el...@apache.org> wrote:
>
>> Hi folks,
>>
>> Here's a formal thread for discussion on merging the space quota feature
>> (presently in the branch HBASE-16961[1]) into master. The tl;dr on the
>> feature is that this extends the RPC quota feature to include configurable
>> limits on the size of tables and namespaces. Please check the archives for
>> earlier discussion on design if you'd like a more in-depth recap.
>>
>> So far, our Ted and Vlad have devoted cycles to reviewing the code and
>> have given their +1's (Ted along the way, Vlad after the fact). Thanks to
>> both of them.
>>
>> Outstanding, I have to commit the feedback from Vlad (due to PreCommit
>> being hosed -- INFRA-13985), and rebase on top of master once more (these
>> have been rather clean/easy to do). Since both of these tasks are pretty
>> minor, I figured we can start the discussion now
>>
>> Thoughts/Opinions? Objections? Approvals? Cat-photos?
>>
>> - Josh
>>
>> [1] https://issues.apache.org/jira/browse/HBASE-16961
>>
>
Re: [DISCUSS] Merge HBASE-16961 (Space Quotas) into master
Posted by Stack <st...@duboce.net>.
Sounds like an excellent idea to me. If I were to take a tour over the
quotas feature, how would you direct my perambulations Josh?
Thanks,
St.Ack
On Tue, Apr 25, 2017 at 9:13 AM, Josh Elser <el...@apache.org> wrote:
> Hi folks,
>
> Here's a formal thread for discussion on merging the space quota feature
> (presently in the branch HBASE-16961[1]) into master. The tl;dr on the
> feature is that this extends the RPC quota feature to include configurable
> limits on the size of tables and namespaces. Please check the archives for
> earlier discussion on design if you'd like a more in-depth recap.
>
> So far, our Ted and Vlad have devoted cycles to reviewing the code and
> have given their +1's (Ted along the way, Vlad after the fact). Thanks to
> both of them.
>
> Outstanding, I have to commit the feedback from Vlad (due to PreCommit
> being hosed -- INFRA-13985), and rebase on top of master once more (these
> have been rather clean/easy to do). Since both of these tasks are pretty
> minor, I figured we can start the discussion now
>
> Thoughts/Opinions? Objections? Approvals? Cat-photos?
>
> - Josh
>
> [1] https://issues.apache.org/jira/browse/HBASE-16961
>