You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/21 22:28:20 UTC

[jira] [Commented] (FLINK-4494) Expose the TimeServiceProvider from the Task to each Operator.

    [ https://issues.apache.org/jira/browse/FLINK-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15511396#comment-15511396 ] 

ASF GitHub Bot commented on FLINK-4494:
---------------------------------------

GitHub user kl0u opened a pull request:

    https://github.com/apache/flink/pull/2532

    [FLINK-4494] Expose the TimeServiceProvider from the Task to each Operator.

    This is a PR for both [FLINK-4496] and [FLINK-4494].
    R: @aljoscha 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kl0u/flink timeprovider_exposing

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2532.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2532
    
----
commit e1522ace235af2a524bce96e180a7d2729c5e6a8
Author: kl0u <kk...@gmail.com>
Date:   2016-08-25T15:38:49Z

    [FLINK-4496] Refactor the TimeServiceProvider to take a Trigerable instead of a Runnable.

commit 2ebdbdafa41d04355cce4b27954c53013d0bc4ba
Author: kl0u <kk...@gmail.com>
Date:   2016-09-21T15:08:29Z

    Updating the PR.

commit 02b120f6bec36c88c9dae9f20fa4b7d74b42cdaf
Author: kl0u <kk...@gmail.com>
Date:   2016-09-20T12:45:01Z

    [FLINK-4494] Expose the TimeServiceProvider from the Task to each Operator.

----


> Expose the TimeServiceProvider from the Task to each Operator.
> --------------------------------------------------------------
>
>                 Key: FLINK-4494
>                 URL: https://issues.apache.org/jira/browse/FLINK-4494
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>
> This change aims at simplifying the {{StreamTask}} class by exposing directly the {{TimeServiceProvider}} to the operators being executed. 
> This implies removing the {{registerTimer()}} and {{getCurrentProcessingTime()}} methods from the {{StreamTask}}. Now, to register a timer and query the time, each operator will be able to get the {{TimeServiceProvider}} and call the corresponding methods directly on it.
> In addition, this will simplify many of the tests which now implement their own time providers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)