[GitHub] [nifi] kevdoran commented on pull request #6329: NIFI-10360 VOLUME declaration prevents updating flow from CI

[GitBox <gi...@apache.org>]

kevdoran commented on PR #6329:
URL: https://github.com/apache/nifi/pull/6329#issuecomment-1233012799

   Thanks for your proposal and reasoning @vitalyzhakov. 
   
   For now, I agree with @exceptionfactory that there are more benefits than downsides to defining the VOLUME inside the Dockerfile. The main downside is when trying to extend the image, but the current images for Apache NiFi are not optimized to be used as base images. Many other people in the community have come up with alternatives images for Apache NiFi that reuse some of the same Dockerfile commands, but do not inherit from apache/nifi.
   
   That said, I'm planning to devote some time this fall to refactoring our approach to Docker images for the project, including separating out the base image from the final image, and also change our approach to sourcing external configurations, which will likely require re-evaluating our use of volumes. If you would like to offer suggestions for changes you would like to see in the Apache NiFi Docker images, we are collecting them here: https://cwiki.apache.org/confluence/display/NIFI/NiFi+Docker+Container+Improvements. You can request write access to the wiki on our [developer mailing list](https://nifi.apache.org/mailing_lists.html) or reply here and I'll be happy to add them to the wiki (with attribution). 
   
   Thanks! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org