You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Ismael Juma <mi...@juma.me.uk> on 2015/04/21 22:56:41 UTC
Review Request 33410: Patch for KAFKA-2034
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33410/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-2034
https://issues.apache.org/jira/browse/KAFKA-2034
Repository: kafka
Description
-------
KAFKA-2034; Set sourceCompatibility in build.gradle
Diffs
-----
build.gradle 4775ee46c480eab7b8250e61ba1705d00f72a6aa
Diff: https://reviews.apache.org/r/33410/diff/
Testing
-------
Thanks,
Ismael Juma
Re: Review Request 33410: Patch for KAFKA-2034
Posted by Ewen Cheslack-Postava <me...@ewencp.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33410/#review81109
-----------------------------------------------------------
Ship it!
Ship It!
- Ewen Cheslack-Postava
On April 21, 2015, 9 p.m., Ismael Juma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33410/
> -----------------------------------------------------------
>
> (Updated April 21, 2015, 9 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2034
> https://issues.apache.org/jira/browse/KAFKA-2034
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-2034; Set sourceCompatibility in build.gradle
>
>
> Diffs
> -----
>
> build.gradle 4775ee46c480eab7b8250e61ba1705d00f72a6aa
>
> Diff: https://reviews.apache.org/r/33410/diff/
>
>
> Testing
> -------
>
> Compiled with JDK 8 and verified that the target level in the bytecode was `50` (ie Java 6) instead of `52`:
>
> find . -name '*.class' | xargs javap -verbose | grep "major version:" | sort | uniq
> major version: 50
>
>
> Thanks,
>
> Ismael Juma
>
>
Re: Review Request 33410: Patch for KAFKA-2034
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33410/#review81600
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On April 21, 2015, 9 p.m., Ismael Juma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33410/
> -----------------------------------------------------------
>
> (Updated April 21, 2015, 9 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2034
> https://issues.apache.org/jira/browse/KAFKA-2034
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-2034; Set sourceCompatibility in build.gradle
>
>
> Diffs
> -----
>
> build.gradle 4775ee46c480eab7b8250e61ba1705d00f72a6aa
>
> Diff: https://reviews.apache.org/r/33410/diff/
>
>
> Testing
> -------
>
> Compiled with JDK 8 and verified that the target level in the bytecode was `50` (ie Java 6) instead of `52`:
>
> find . -name '*.class' | xargs javap -verbose | grep "major version:" | sort | uniq
> major version: 50
>
>
> Thanks,
>
> Ismael Juma
>
>
Re: Review Request 33410: Patch for KAFKA-2034
Posted by Ismael Juma <mi...@juma.me.uk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33410/
-----------------------------------------------------------
(Updated April 21, 2015, 9 p.m.)
Review request for kafka.
Bugs: KAFKA-2034
https://issues.apache.org/jira/browse/KAFKA-2034
Repository: kafka
Description
-------
KAFKA-2034; Set sourceCompatibility in build.gradle
Diffs
-----
build.gradle 4775ee46c480eab7b8250e61ba1705d00f72a6aa
Diff: https://reviews.apache.org/r/33410/diff/
Testing (updated)
-------
Compiled with JDK 8 and verified that the target level in the bytecode was `50` (ie Java 6) instead of `52`:
find . -name '*.class' | xargs javap -verbose | grep "major version:" | sort | uniq
major version: 50
Thanks,
Ismael Juma