You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "jiafu1115 (via GitHub)" <gi...@apache.org> on 2025/12/21 02:47:39 UTC
[PR] MINOR: improve the ci: avoid run the long time test if only document changed [kafka]
jiafu1115 opened a new pull request, #21199:
URL: https://github.com/apache/kafka/pull/21199
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long tests when only document is changed [kafka]
Posted by "jiafu1115 (via GitHub)" <gi...@apache.org>.
jiafu1115 commented on PR #21199:
URL: https://github.com/apache/kafka/pull/21199#issuecomment-3678434753
If the documents have special check or test or have plan for it ，this pr is not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long time tests when only document is changed [kafka]
Posted by "jiafu1115 (via GitHub)" <gi...@apache.org>.
jiafu1115 commented on PR #21199:
URL: https://github.com/apache/kafka/pull/21199#issuecomment-3682541496
Test with follow **tmp** configure:
filters: |
codes:
- '**'
- '!**/*.yml'
- '!**/*.md'
### Test Case 1
Change two files:
build.yml and CustomQuotaCallbackTest.java
The result:
Filter codes = true
Matching files:
clients/clients-integration-tests/src/test/java/org/apache/kafka/server/quota/CustomQuotaCallbackTest.java [modified]
### Test Case 2
Change one files
build.yml
The result:
Filter codes = false
Matching files: none
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long time tests when only document is changed [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21199:
URL: https://github.com/apache/kafka/pull/21199#issuecomment-5612414758
This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long time tests when only document is changed [kafka]
Posted by "jiafu1115 (via GitHub)" <gi...@apache.org>.
jiafu1115 commented on PR #21199:
URL: https://github.com/apache/kafka/pull/21199#issuecomment-3684808292
@mumrah @chia7712 @Pankraz76
Done for the code refactor and tests. I also add more file type which need to be exclude from tests.
It is the final status for me now. If you think it is worthy for this PR. you can help to review. Thanks.
### Test 1: Only doc change
<img width="658" height="562" alt="image" src="https://github.com/user-attachments/assets/0322ebc8-b387-4ff9-8ddd-2b959569ee3c" />
### Test 2: Only code change
<img width="571" height="425" alt="image" src="https://github.com/user-attachments/assets/2b87e9e6-0368-4a0c-b143-e827f4a47656" />
### Test 3: Code and Doc changed
<img width="787" height="527" alt="image" src="https://github.com/user-attachments/assets/f6c84fae-b2b8-475d-8d01-bf1d9dda6e98" />
BTW. I record some information found in tests here for your reference:
1 "predicate-quantifier: 'every'" will got one warn log but it shouldn't be deleted due to the behavior will be changed accroding to the test result.
`_Warning: Unexpected input(s) 'predicate-quantifier', valid inputs are ['token', 'working-directory', 'ref', 'base', 'filters', 'list-files', 'initial-fetch-depth']_`
2 ${{ steps.filter.outputs.docs && !steps.filter.outputs.codes }}" **is not equal with** ${{ steps.filter.outputs.docs == 'true' && steps.filter.outputs.codes == 'false' }}". @Pankraz76 so I rollback part of the code. I also check the plugin example. you can check my test result here directly.
```
echo "steps.filter.outputs.docs: ${{ steps.filter.outputs.docs }}"
echo "steps.filter.outputs.codes: ${{ steps.filter.outputs.codes }}"
echo "doc-change-only: ${{ steps.filter.outputs.docs && !steps.filter.outputs.codes }}"
echo "doc-change-only: ${{ steps.filter.outputs.docs == 'true' && steps.filter.outputs.codes == 'false' }}"
the result: true. false. false, true
```
Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long time tests when only document is changed [kafka]
Posted by "jiafu1115 (via GitHub)" <gi...@apache.org>.
jiafu1115 commented on code in PR #21199:
URL: https://github.com/apache/kafka/pull/21199#discussion_r3136215155
##########
.github/workflows/build.yml:
##########
@@ -175,7 +197,7 @@ jobs:
test:
needs: [configure, validate, load-catalog]
- if: ${{ ! needs.configure.outputs.is-draft }}
+ if: ${{ !needs.configure.outputs.is-draft && needs.configure.outputs.doc-change-only != 'true' }}
Review Comment:
@Pankraz76 thanks for your comment. It looks like no one is particularly interested in this PR or want this PR, so I’ll keep things as they are for now. That said, I really appreciate your comments—thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long time tests when only document is changed [kafka]
Posted by "jiafu1115 (via GitHub)" <gi...@apache.org>.
jiafu1115 commented on PR #21199:
URL: https://github.com/apache/kafka/pull/21199#issuecomment-3682642261
> Ideally, we don't need this since the Gradle build cache should avoid running tests if no source files have changed. But we still don't have that working perfectly, so an explicit opt-out of tests seems okay for docs changes.
>
> We should still run the "Compile and Check (Merge Ref)" job since it checks for licenses.
@mumrah thanks for your feedback. at the last. adopt the @chia7712 's suggestion. just ignore the test for document change only. example:
https://github.com/apache/kafka/actions/runs/20434902642
"But we still don't have that working perfectly,"- That's maybe the root cause I see some document only take few time when some other take a long of time.
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long time tests when only document is changed [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #21199:
URL: https://github.com/apache/kafka/pull/21199#issuecomment-3682671987
> That's maybe the root cause
Yes, very likely. I have an explanation here https://github.com/apache/kafka/pull/18449#issuecomment-2594038906
Essentially, we checkout `${{ github.event.pull_request.head.sha }}` which is the HEAD of the PR branch rather than the special "merge ref". This means if a docs PR is far behind trunk, we will get mostly cache misses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long time tests when only document is changed [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #21199:
URL: https://github.com/apache/kafka/pull/21199#issuecomment-3682701673
> Ideally, we don't need this since the Gradle build cache should avoid running tests if no source files have changed.
That would be the dream :smile: I really hope we can make that happen one day
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long tests when only document is changed [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #21199:
URL: https://github.com/apache/kafka/pull/21199#issuecomment-3678421763
@mumrah do you plan to add tests specifically for the documentation changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long time tests when only document is changed [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21199:
URL: https://github.com/apache/kafka/pull/21199#issuecomment-4115288660
This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.
<p>
If you are having difficulty finding a reviewer, please reach out on the
[mailing list](https://kafka.apache.org/contact).
<p>
If this PR is no longer valid or desired, please feel free to close it. If no activity
occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long time tests when only document is changed [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #21199:
URL: https://github.com/apache/kafka/pull/21199#issuecomment-3678507445
Perhaps we can keep the check but skip test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long time tests when only document is changed [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #21199:
URL: https://github.com/apache/kafka/pull/21199#discussion_r3008105133
##########
.github/workflows/build.yml:
##########
@@ -175,7 +197,7 @@ jobs:
test:
needs: [configure, validate, load-catalog]
- if: ${{ ! needs.configure.outputs.is-draft }}
+ if: ${{ !needs.configure.outputs.is-draft && needs.configure.outputs.doc-change-only != 'true' }}
Review Comment:
```suggestion
if: ${{ !needs.configure.outputs.is-draft && needs.configure.outputs.doc-change-only}}
```
imho you could use the native boolean interpretation.
You might need to negate, but you dont need to manually evaluate the boolean yourself.
just like seen in the EXP before. `!needs.configure.outputs.is-draft`
this feels like feature envy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long time tests when only document is changed [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #21199: MINOR: Improve the CI to avoid running long time tests when only document is changed
URL: https://github.com/apache/kafka/pull/21199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long time tests when only document is changed [kafka]
Posted by "jiafu1115 (via GitHub)" <gi...@apache.org>.
jiafu1115 commented on code in PR #21199:
URL: https://github.com/apache/kafka/pull/21199#discussion_r2639845506
##########
.github/workflows/build.yml:
##########
@@ -59,9 +60,28 @@ jobs:
echo "days=7" >> "$GITHUB_OUTPUT"
echo "sha=${{ github.sha }}" >> "$GITHUB_OUTPUT"
fi
+ - name: Checkout code
+ uses: actions/checkout@v5
+ with:
+ persist-credentials: false
+ - name: Filter changed files
+ id: filter
+ uses: dorny/paths-filter@v2
Review Comment:
@chia7712 thanks for your reminder. done with the change according to https://github.com/apache/infrastructure-actions/blob/135d8bf57bd3eccd6812ca34d8bad888e7e75e5b/actions.yml#L311C1-L312C1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long time tests when only document is changed [kafka]
Posted by "jiafu1115 (via GitHub)" <gi...@apache.org>.
jiafu1115 commented on PR #21199:
URL: https://github.com/apache/kafka/pull/21199#issuecomment-3682721399
@chia7712 @mumrah so. does this PR make sense to do?
the dream example: **stable within few time**:
<img width="1865" height="515" alt="image" src="https://github.com/user-attachments/assets/66fc6a54-47aa-4718-808b-6d8fb0858f66" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long time tests when only document is changed [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21199:
URL: https://github.com/apache/kafka/pull/21199#issuecomment-5066191180
This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.
<p>
If you are having difficulty finding a reviewer, please reach out on the
[mailing list](https://kafka.apache.org/contact).
<p>
If this PR is no longer valid or desired, please feel free to close it. If no activity
occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long time tests when only document is changed [kafka]
Posted by "Pankraz76 (via GitHub)" <gi...@apache.org>.
Pankraz76 commented on code in PR #21199:
URL: https://github.com/apache/kafka/pull/21199#discussion_r2637851025
##########
.github/workflows/build.yml:
##########
@@ -380,7 +400,7 @@ jobs:
exit 1
- name: Check Dependency Outcomes
run: |
- if [[ "${{ needs.validate.result }}" == "success" && "${{ needs.test.result }}" == "success" ]]; then
+ if [[ "${{ needs.validate.result }}" == "success" && ("${{ needs.configure.outputs.docChangeOnly }}" == "true" || "${{ needs.test.result }}" == "success") ]]; then
Review Comment:
```suggestion
if [[ "${{ needs.validate.result }}" == "success" && (${{ needs.configure.outputs.docChangeOnly }} || "${{ needs.test.result }}" == "success") ]]; then
```
is it possible to to like above, using system check for the value?
##########
.github/workflows/build.yml:
##########
@@ -175,7 +195,7 @@ jobs:
test:
needs: [configure, validate, load-catalog]
- if: ${{ ! needs.configure.outputs.is-draft }}
Review Comment:
nice fix.
##########
.github/workflows/build.yml:
##########
@@ -38,6 +38,7 @@ jobs:
is-draft: ${{ steps.check-draft-pr.outputs.is-draft }}
test-catalog-days: ${{ steps.configure-outputs.outputs.days }}
sha: ${{ steps.configure-outputs.outputs.sha }}
+ docChangeOnly: ${{ steps.filter.outputs.docs == 'true' && steps.filter.outputs.code == 'false' }}
Review Comment:
```suggestion
docChangeOnly: ${{ steps.filter.outputs.docs && !steps.filter.outputs.code }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long time tests when only document is changed [kafka]
Posted by "jiafu1115 (via GitHub)" <gi...@apache.org>.
jiafu1115 commented on PR #21199:
URL: https://github.com/apache/kafka/pull/21199#issuecomment-3678556423
> Perhaps we can keep the check but skip test
@chia7712 done with change. to be honest the code is generated by AI with my review. It needs test with this CI and another CI with document change only. you can help to check if the approach make sense now. thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Improve the CI to avoid running long time tests when only document is changed [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #21199:
URL: https://github.com/apache/kafka/pull/21199#discussion_r2639530429
##########
.github/workflows/build.yml:
##########
@@ -59,9 +60,28 @@ jobs:
echo "days=7" >> "$GITHUB_OUTPUT"
echo "sha=${{ github.sha }}" >> "$GITHUB_OUTPUT"
fi
+ - name: Checkout code
+ uses: actions/checkout@v5
+ with:
+ persist-credentials: false
+ - name: Filter changed files
+ id: filter
+ uses: dorny/paths-filter@v2
Review Comment:
Per Apache policy, we need to use git hash instead of tag version
https://infra.apache.org/github-actions-policy.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org