You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@groovy.apache.org by shils <gi...@git.apache.org> on 2016/06/20 14:54:22 UTC

[GitHub] groovy pull request #348: Groovy7860 AutoImplement transform

Github user shils commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/348#discussion_r67703766
  
    --- Diff: src/main/groovy/transform/Undefined.java ---
    @@ -28,6 +28,10 @@
         private Undefined() {}
         public static final String STRING = "<DummyUndefinedMarkerString-DoNotUse>";
         public static final class CLASS {}
    +    public static final class UNDEFINED_EXCEPTION extends RuntimeException {
    --- End diff --
    
    I think it would be more in line with the other Undefined fields if the 'UNDEFINED_' prefix were dropped from the field name e.g. 'EXCEPTION_CLASS' or something to that effect.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---