You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by "John Plevyak (JIRA)" <ji...@apache.org> on 2010/02/01 21:38:18 UTC
[jira] Created: (TS-130) we should generate a config.h file instead
of putting all the -Ds in the CFLAGS
we should generate a config.h file instead of putting all the -Ds in the CFLAGS
-------------------------------------------------------------------------------
Key: TS-130
URL: https://issues.apache.org/jira/browse/TS-130
Project: Traffic Server
Issue Type: Improvement
Reporter: John Plevyak
We should use a config.h instead of a huge pile of -Ds
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-130) we should generate a config.h file
instead of putting all the -Ds in the CFLAGS
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831109#action_12831109 ]
Leif Hedstrom commented on TS-130:
----------------------------------
v3 looks good to me, reviewed=leif.
> we should generate a config.h file instead of putting all the -Ds in the CFLAGS
> -------------------------------------------------------------------------------
>
> Key: TS-130
> URL: https://issues.apache.org/jira/browse/TS-130
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: John Plevyak
> Assignee: John Plevyak
> Attachments: config.h-jp-v1.patch, ts-config.h-jp-v2.patch, ts-config.h-jp-v3.patch
>
>
> We should use a config.h instead of a huge pile of -Ds
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-130) we should generate a config.h file instead
of putting all the -Ds in the CFLAGS
Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Plevyak updated TS-130:
----------------------------
Attachment: config.h-jp-v1.patch
This is a patch to the dev branch which implements this. Since it is just cleanup
and since it touches lots of stuff and that inherently has some risk, I don't think
this should go into 2.0.0.
> we should generate a config.h file instead of putting all the -Ds in the CFLAGS
> -------------------------------------------------------------------------------
>
> Key: TS-130
> URL: https://issues.apache.org/jira/browse/TS-130
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: John Plevyak
> Assignee: John Plevyak
> Attachments: config.h-jp-v1.patch
>
>
> We should use a config.h instead of a huge pile of -Ds
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TS-130) we should generate a config.h file
instead of putting all the -Ds in the CFLAGS
Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Plevyak resolved TS-130.
-----------------------------
Resolution: Fixed
Fix Version/s: 2.1.0
Committed revision 907798.
> we should generate a config.h file instead of putting all the -Ds in the CFLAGS
> -------------------------------------------------------------------------------
>
> Key: TS-130
> URL: https://issues.apache.org/jira/browse/TS-130
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: John Plevyak
> Assignee: John Plevyak
> Fix For: 2.1.0
>
> Attachments: config.h-jp-v1.patch, ts-config.h-jp-v2.patch, ts-config.h-jp-v3.patch
>
>
> We should use a config.h instead of a huge pile of -Ds
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-130) we should generate a config.h file
instead of putting all the -Ds in the CFLAGS
Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831063#action_12831063 ]
John Plevyak commented on TS-130:
---------------------------------
I am still getting the hang of git and I seem to have mixed up some other changes into this
this patch which needs to be cleaned up to include only the config.h changes.
I'll rebuild the patch.
... DDebug is short for DebugDebug since we decided to keep Debug diags in
the release version and there are things in the cache which really for use on DEBUG builds they
would be DebugDebug (or perhaps ReallyDebug ? :) . Several subsystems turn off the some
Diags for release builds because the engineers who wrote never intended them for release builds
and so there are several incompatible ways they did it. The saddest commentary on this battle
is in logging where the author #define NO_DIAGS and then someone else explicity
#undef NO_DIAGS in the Diags.h header in response.
I would like to propose that we use Diag("xxx") for diags that are available all the time and
Debug("xx") for diags that are only available on DEBUG builds and standardize the way to
specify which builds a particular diagnostic message will be available in.
> we should generate a config.h file instead of putting all the -Ds in the CFLAGS
> -------------------------------------------------------------------------------
>
> Key: TS-130
> URL: https://issues.apache.org/jira/browse/TS-130
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: John Plevyak
> Assignee: John Plevyak
> Attachments: config.h-jp-v1.patch, ts-config.h-jp-v2.patch
>
>
> We should use a config.h instead of a huge pile of -Ds
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-130) we should generate a config.h file
instead of putting all the -Ds in the CFLAGS
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831075#action_12831075 ]
Leif Hedstrom commented on TS-130:
----------------------------------
Alright, I'll do another review with the new diffs :).
The reason I asked about DDebug() was because it was used in the v2 patch, but I couldn't see it defined anywhere.
Finally, +1 on the proposal to Diag(). I'd like to add to that that it'd be really great if we came up with a better, well organized "tree" of tags for the diagnostics messages. Right now, it's a crapshoot what you will get when tracing on say '.*http.*'.
> we should generate a config.h file instead of putting all the -Ds in the CFLAGS
> -------------------------------------------------------------------------------
>
> Key: TS-130
> URL: https://issues.apache.org/jira/browse/TS-130
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: John Plevyak
> Assignee: John Plevyak
> Attachments: config.h-jp-v1.patch, ts-config.h-jp-v2.patch
>
>
> We should use a config.h instead of a huge pile of -Ds
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-130) we should generate a config.h file instead
of putting all the -Ds in the CFLAGS
Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Plevyak updated TS-130:
----------------------------
Attachment: ts-config.h-jp-v2.patch
cleaned up as per Leif's comments
> we should generate a config.h file instead of putting all the -Ds in the CFLAGS
> -------------------------------------------------------------------------------
>
> Key: TS-130
> URL: https://issues.apache.org/jira/browse/TS-130
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: John Plevyak
> Assignee: John Plevyak
> Attachments: config.h-jp-v1.patch, ts-config.h-jp-v2.patch
>
>
> We should use a config.h instead of a huge pile of -Ds
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-130) we should generate a config.h file
instead of putting all the -Ds in the CFLAGS
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831016#action_12831016 ]
Leif Hedstrom commented on TS-130:
----------------------------------
Couple of questions still :)
1) What is DDebug ? Is that something new on the dev trunk too ?
2) This patch looks better, but it still has a fair amount of changes that I'm not sure understand why they would be part of this bug / patch? They seem mostly cosmetic, e.g. changing CacheDebug to Debug (but also see the above about changes to DDebug). But there are some significant changes to DNS.cc for example in the v2 patch still, is that really intended?
> we should generate a config.h file instead of putting all the -Ds in the CFLAGS
> -------------------------------------------------------------------------------
>
> Key: TS-130
> URL: https://issues.apache.org/jira/browse/TS-130
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: John Plevyak
> Assignee: John Plevyak
> Attachments: config.h-jp-v1.patch, ts-config.h-jp-v2.patch
>
>
> We should use a config.h instead of a huge pile of -Ds
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-130) we should generate a config.h file instead
of putting all the -Ds in the CFLAGS
Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Plevyak updated TS-130:
----------------------------
Attachment: ts-config.h-jp-v3.patch
Ok, I think I finally cleaned up the patch. I had some stale stuff check into git locally
which was messing things up.
There is still a minor formatting change in DNS but that is all whitespace
which indent hosed.
> we should generate a config.h file instead of putting all the -Ds in the CFLAGS
> -------------------------------------------------------------------------------
>
> Key: TS-130
> URL: https://issues.apache.org/jira/browse/TS-130
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: John Plevyak
> Assignee: John Plevyak
> Attachments: config.h-jp-v1.patch, ts-config.h-jp-v2.patch, ts-config.h-jp-v3.patch
>
>
> We should use a config.h instead of a huge pile of -Ds
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TS-130) we should generate a config.h file
instead of putting all the -Ds in the CFLAGS
Posted by "John Plevyak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Plevyak reassigned TS-130:
-------------------------------
Assignee: John Plevyak
> we should generate a config.h file instead of putting all the -Ds in the CFLAGS
> -------------------------------------------------------------------------------
>
> Key: TS-130
> URL: https://issues.apache.org/jira/browse/TS-130
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: John Plevyak
> Assignee: John Plevyak
>
> We should use a config.h instead of a huge pile of -Ds
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.