You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Cassie Doll (JIRA)" <ji...@apache.org> on 2008/04/15 17:59:05 UTC
[jira] Created: (SHINDIG-199) Move the social java code into the
java/social-api component
Move the social java code into the java/social-api component
------------------------------------------------------------
Key: SHINDIG-199
URL: https://issues.apache.org/jira/browse/SHINDIG-199
Project: Shindig
Issue Type: Improvement
Components: RESTful API (Java)
Reporter: Cassie Doll
Assignee: Cassie Doll
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-199) Move the social java code into the
java/social-api component
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cassie Doll closed SHINDIG-199.
-------------------------------
Resolution: Fixed
See SHINDIG-200 for more progress on this.
> Move the social java code into the java/social-api component
> ------------------------------------------------------------
>
> Key: SHINDIG-199
> URL: https://issues.apache.org/jira/browse/SHINDIG-199
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Cassie Doll
> Assignee: Cassie Doll
> Attachments: move_social_code.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-199) Move the social java code into the
java/social-api component
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589497#action_12589497 ]
Cassie Doll commented on SHINDIG-199:
-------------------------------------
Okay, it doesn't look like there are any huge blockers here, so I am actually going to submit this change so that we can fix it up further in additional patches. The first one is coming from Ian to help us use maven and jetty better. Next will be the java/common fix (addressing Vasu's comment) and then we will make sure the social stuff all works still (addressing Chris's comment).
> Move the social java code into the java/social-api component
> ------------------------------------------------------------
>
> Key: SHINDIG-199
> URL: https://issues.apache.org/jira/browse/SHINDIG-199
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Cassie Doll
> Assignee: Cassie Doll
> Attachments: move_social_code.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-199) Move the social java code into the
java/social-api component
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589141#action_12589141 ]
Santiago Gala commented on SHINDIG-199:
---------------------------------------
Does not apply here. I think subversion gets confused by the deletions/moves and produces a patch that starts:
Index: java/social-api/src/main/java/org/apache/shindig/social/samplecontainer/XmlStateFileFetcher.java
===================================================================
--- java/social-api/src/main/java/org/apache/shindig/social/samplecontainer/XmlStateFileFetcher.java (revision 647714)
+++ java/social-api/src/main/java/org/apache/shindig/social/samplecontainer/XmlStateFileFetcher.java (working copy)
while java/social-api/src/main/java does not exist here. I can move it by hand but there are more files moved.
I guess you need to tell subversion some other options for it to produce a working patch. :(
> Move the social java code into the java/social-api component
> ------------------------------------------------------------
>
> Key: SHINDIG-199
> URL: https://issues.apache.org/jira/browse/SHINDIG-199
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Cassie Doll
> Assignee: Cassie Doll
> Attachments: move_social_code.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-199) Move the social java code into the
java/social-api component
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589485#action_12589485 ]
Chris Chabot commented on SHINDIG-199:
--------------------------------------
>From the PHP perspective my main interest in this would be the different URL structure (/gadgets and /socialdata as top level url's instead of the /gadgets & /gadgets/socialdata as it exists now).
Looking at the patch i do see some url-pattern changes, however my knowledge of how the configuration works on the java side of things is insufficient to judge if this would indeed move the URL as i hope, or not.
If it does however change the URL to the social data interface, this patch should also patch config.js:
"opensocial-0.7" : {
// Path to fetch opensocial data from
// Must be on the same domain as the gadget rendering server
"path" : "/gadgets/socialdata",
> Move the social java code into the java/social-api component
> ------------------------------------------------------------
>
> Key: SHINDIG-199
> URL: https://issues.apache.org/jira/browse/SHINDIG-199
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Cassie Doll
> Assignee: Cassie Doll
> Attachments: move_social_code.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-199) Move the social java code into the
java/social-api component
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589496#action_12589496 ]
Cassie Doll commented on SHINDIG-199:
-------------------------------------
Thanks for the comment Chris. This patch actually breaks all of the social stuff...because the java side right now can't achieve same domain. Ian is going to get something running with this patch though: https://issues.apache.org/jira/browse/SHINDIG-200 so as soon as we get it working we will fix the config.js file.
Feel free to change the config.js file to whatever the php needs it to be though. We can keep working with the java deployment until we get them to match.
> Move the social java code into the java/social-api component
> ------------------------------------------------------------
>
> Key: SHINDIG-199
> URL: https://issues.apache.org/jira/browse/SHINDIG-199
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Cassie Doll
> Assignee: Cassie Doll
> Attachments: move_social_code.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-199) Move the social java code into the
java/social-api component
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cassie Doll updated SHINDIG-199:
--------------------------------
Attachment: move_social_code.patch
If you ignore all of the deletions, the patch itself is pretty short.
> Move the social java code into the java/social-api component
> ------------------------------------------------------------
>
> Key: SHINDIG-199
> URL: https://issues.apache.org/jira/browse/SHINDIG-199
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Cassie Doll
> Assignee: Cassie Doll
> Attachments: move_social_code.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-199) Move the social java code into the
java/social-api component
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589473#action_12589473 ]
Cassie Doll commented on SHINDIG-199:
-------------------------------------
I absolutely agree that the dependency is horrible. Unfortunately, simply refactoring XmlStateFileFetcher will not remove all of the gadgets dependencies. The second step in refactoring all of our code is to make a java/common directory with all of the common code (including the content fetcher) in it.
With that in mind, I think trying to refactor all of the common dependencies away would make this change huge and unbearable. The next step will be to immediately fix that though.
As for AbstractGadgetData, my hopes were that all of this data fetching stuff will become more general and encompass non-social things.. that's why the servlet is called GadgetDataServlet. There's been some talk about the restful spec allowing non-social data as well (like music and whatnot). You make a good point though, we should probably rename it in a later change.
> Move the social java code into the java/social-api component
> ------------------------------------------------------------
>
> Key: SHINDIG-199
> URL: https://issues.apache.org/jira/browse/SHINDIG-199
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Cassie Doll
> Assignee: Cassie Doll
> Attachments: move_social_code.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-199) Move the social java code into the
java/social-api component
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589155#action_12589155 ]
Cassie Doll commented on SHINDIG-199:
-------------------------------------
In my svn client I did "svn mv" rather than add and delete. When I do svn status they show up as D, and A*.
The diff itself does show changes to moved files which were modified (take the XmlStateFetcher for instance), all moved files that were not modified are not in the diff though. I have no idea why this happens... I just did svn diff > mypatch. Is there a better way to do it?
If not, well then I can still submit from my client and it will turn out alright (other svn mv's have done so in the past)... I'm not sure how to fix the diff itself, but at least it is still readable if you pretend the moves are deletes :)
Any ideas?
> Move the social java code into the java/social-api component
> ------------------------------------------------------------
>
> Key: SHINDIG-199
> URL: https://issues.apache.org/jira/browse/SHINDIG-199
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Cassie Doll
> Assignee: Cassie Doll
> Attachments: move_social_code.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-199) Move the social java code into the
java/social-api component
Posted by "vasu nori (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589174#action_12589174 ]
vasu nori commented on SHINDIG-199:
-----------------------------------
XmlStateFileFetcher.java could use some refactoring during this patch. It currently uses ContentFetcher to get at the sample data xml file. That introduces dependency with code in java/gadgets dir code (BasicRemoteContentFetcher).
I'd say, there should be NO dependency by java/social/ on code in java/gadgets/ code.
XmlStateFileFetcher could simply do file I/O to read the XML file, to remove this particular dependency.
and a nitpick: all POJOs in social/opensocial/model/ extend AbstractGadgetData. It should be called AbstractModelEntity or something and remove the word "gadget" from it.
> Move the social java code into the java/social-api component
> ------------------------------------------------------------
>
> Key: SHINDIG-199
> URL: https://issues.apache.org/jira/browse/SHINDIG-199
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Cassie Doll
> Assignee: Cassie Doll
> Attachments: move_social_code.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-199) Move the social java code into the
java/social-api component
Posted by "David Primmer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589152#action_12589152 ]
David Primmer commented on SHINDIG-199:
---------------------------------------
Yeah, this is a delete patch and not a move patch. It looks like you didn't do the work to have svn track that these files were moved. I think you need to either revert the changes you made and use svn move on each file or if you want just finish this off, you can do svn adds of all the files you moved and then create the patch from that svn diff.
> Move the social java code into the java/social-api component
> ------------------------------------------------------------
>
> Key: SHINDIG-199
> URL: https://issues.apache.org/jira/browse/SHINDIG-199
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Cassie Doll
> Assignee: Cassie Doll
> Attachments: move_social_code.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.