You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/06/28 12:54:08 UTC

[GitHub] [airflow] XD-DENG commented on a change in pull request #5501: [AIRFLOW-4862] Allow directly using IP address as hostname

XD-DENG commented on a change in pull request #5501: [AIRFLOW-4862] Allow directly using IP address as hostname
URL: https://github.com/apache/airflow/pull/5501#discussion_r298580815
 
 

 ##########
 File path: airflow/utils/net.py
 ##########
 @@ -38,6 +38,14 @@ def get_hostname():
     if not callable_path:
         return socket.getfqdn()
 
+    # Use IP address if callable_path is configured as "use_ip_address"
+    # Fallback to socket.getfqdn() if there is error.
+    if callable_path == "use_ip_address":
 
 Review comment:
   Good idea. Let me address accordingly. Thanks @ashb 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services