You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/10 02:05:37 UTC
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10278: chore: add typing to more sqllab components
codecov-commenter commented on pull request #10278:
URL: https://github.com/apache/incubator-superset/pull/10278#issuecomment-656439924
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10278?src=pr&el=h1) Report
> Merging [#10278](https://codecov.io/gh/apache/incubator-superset/pull/10278?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a460fdf0f84ee9da1696cbf54d1018d0114a3dfb&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10278?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10278 +/- ##
==========================================
- Coverage 70.19% 70.11% -0.08%
==========================================
Files 598 598
Lines 32017 32009 -8
Branches 3240 3237 -3
==========================================
- Hits 22474 22443 -31
- Misses 9438 9458 +20
- Partials 105 108 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.94% <0.00%> (-0.45%)` | :arrow_down: |
| #javascript | `59.40% <75.00%> (+0.07%)` | :arrow_up: |
| #python | `69.68% <ø> (ø)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10278?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/constants.ts](https://codecov.io/gh/apache/incubator-superset/pull/10278/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb25zdGFudHMudHM=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10278/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC50c3g=) | `25.00% <ø> (ø)` | |
| [...uperset-frontend/src/SqlLab/components/ShowSQL.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10278/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Nob3dTUUwudHN4) | `80.00% <33.33%> (ø)` | |
| [...t-frontend/src/SqlLab/components/ColumnElement.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10278/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0NvbHVtbkVsZW1lbnQudHN4) | `100.00% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/10278/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10278/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `77.27% <0.00%> (-5.20%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10278/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10278/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10278/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (-2.36%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/10278/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10278?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10278?src=pr&el=footer). Last update [a460fdf...8f8e902](https://codecov.io/gh/apache/incubator-superset/pull/10278?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org