You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/05/06 04:00:48 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #5337: Track unavailable segments in InstanceSelector
codecov-io edited a comment on pull request #5337:
URL: https://github.com/apache/incubator-pinot/pull/5337#issuecomment-624429374
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5337?src=pr&el=h1) Report
> Merging [#5337](https://codecov.io/gh/apache/incubator-pinot/pull/5337?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/52001be6e37f07a7359766021df9495f7112fae9&el=desc) will **increase** coverage by `9.48%`.
> The diff coverage is `86.79%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/5337/graphs/tree.svg?width=650&height=150&src=pr&token=4ibza2ugkz)](https://codecov.io/gh/apache/incubator-pinot/pull/5337?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5337 +/- ##
==========================================
+ Coverage 56.88% 66.36% +9.48%
==========================================
Files 1073 1075 +2
Lines 54722 54780 +58
Branches 8159 8168 +9
==========================================
+ Hits 31126 36355 +5229
+ Misses 21149 15753 -5396
- Partials 2447 2672 +225
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5337?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rg/apache/pinot/broker/routing/RoutingManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5337/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9Sb3V0aW5nTWFuYWdlci5qYXZh) | `78.62% <50.00%> (+12.85%)` | :arrow_up: |
| [...org/apache/pinot/broker/api/RequestStatistics.java](https://codecov.io/gh/apache/incubator-pinot/pull/5337/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYXBpL1JlcXVlc3RTdGF0aXN0aWNzLmphdmE=) | `64.51% <66.66%> (+64.51%)` | :arrow_up: |
| [...e/pinot/broker/api/resources/PinotBrokerDebug.java](https://codecov.io/gh/apache/incubator-pinot/pull/5337/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYXBpL3Jlc291cmNlcy9QaW5vdEJyb2tlckRlYnVnLmphdmE=) | `79.31% <75.00%> (+79.31%)` | :arrow_up: |
| [...roker/requesthandler/BaseBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/5337/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQmFzZUJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `79.89% <81.81%> (+59.73%)` | :arrow_up: |
| [...routing/instanceselector/BaseInstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5337/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9pbnN0YW5jZXNlbGVjdG9yL0Jhc2VJbnN0YW5jZVNlbGVjdG9yLmphdmE=) | `98.01% <96.22%> (+9.44%)` | :arrow_up: |
| [.../org/apache/pinot/broker/routing/RoutingTable.java](https://codecov.io/gh/apache/incubator-pinot/pull/5337/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9Sb3V0aW5nVGFibGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ker/routing/instanceselector/InstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5337/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9pbnN0YW5jZXNlbGVjdG9yL0luc3RhbmNlU2VsZWN0b3IuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...org/apache/pinot/broker/queryquota/HitCounter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5337/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IaXRDb3VudGVyLmphdmE=) | `92.30% <0.00%> (-7.70%)` | :arrow_down: |
| [.../realtime/impl/ThreadSafeMutableRoaringBitmap.java](https://codecov.io/gh/apache/incubator-pinot/pull/5337/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL1RocmVhZFNhZmVNdXRhYmxlUm9hcmluZ0JpdG1hcC5qYXZh) | `92.85% <0.00%> (-7.15%)` | :arrow_down: |
| [...he/pinot/controller/util/SegmentIntervalUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5337/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci91dGlsL1NlZ21lbnRJbnRlcnZhbFV0aWxzLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [328 more](https://codecov.io/gh/apache/incubator-pinot/pull/5337/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5337?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5337?src=pr&el=footer). Last update [52001be...584eea6](https://codecov.io/gh/apache/incubator-pinot/pull/5337?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org