[GitHub] [solr] dsmiley commented on pull request #288: SOLR-6910: A deleteById request without _route_ param for implicit router could be sent to all shard leaders

[GitBox <gi...@apache.org>]

dsmiley commented on pull request #288:
URL: https://github.com/apache/solr/pull/288#issuecomment-944654502


   Sorry, I find having `doDeleteById` call `doDeleteByQuery` to be way too kludgy (and you admitted as much in JIRA).  It appears that this works almost accidentally, and is thus fragile and perhaps internally slower than it could be.  It seems the logic should go into `doDistribDeleteById`.
   
   But firstly, I'm confused about how this PR relates to the JIRA issue.  The JIRA issue clearly states this issue occurs when the implicit router is being used.  Yet the test here and the fix use/check-for the CompositeIdRouter.  Am I missing something?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org