You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2018/05/26 17:34:33 UTC

[GitHub] ctubbsii commented on a change in pull request #501: Improve some comparators using Java 8

ctubbsii commented on a change in pull request #501: Improve some comparators using Java 8
URL: https://github.com/apache/accumulo/pull/501#discussion_r191054266
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/iterators/IteratorUtil.java
 ##########
 @@ -72,15 +71,8 @@
     majc, minc, scan;
   }
 
-  public static class IterInfoComparator implements Comparator<IterInfo>, Serializable {
-    private static final long serialVersionUID = 1L;
-
-    @Override
-    public int compare(IterInfo o1, IterInfo o2) {
-      return (o1.priority < o2.priority ? -1 : (o1.priority == o2.priority ? 0 : 1));
-    }
-
-  }
+  private static Comparator<IterInfo> II_COMPARATOR = Comparator
 
 Review comment:
   This could use a better name (`ITER_INFO_COMPARATOR`?), and could be final.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services