You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/12/15 11:48:45 UTC

[GitHub] [apisix] tokers commented on a change in pull request #5821: feat(plugins): make plugins more powerfull

tokers commented on a change in pull request #5821:
URL: https://github.com/apache/apisix/pull/5821#discussion_r769552400



##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -592,7 +592,7 @@ http {
             set $dubbo_method                '';
             {% end %}
 
-            access_by_lua_block {
+            rewrite_by_lua_block {

Review comment:
       I am afraid we'd better have a discussion about this, this change breaks the original design purposes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org