[jira] [Commented] (HBASE-13568) Make Waiter class a public API.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-13568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512945#comment-14512945 ] 

Hadoop QA commented on HBASE-13568:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12728204/HBASE-13568.patch
  against master branch at commit cd83d39fb4f50db901b699ba5470b5f709c95c69.
  ATTACHMENT ID: 12728204

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 85 new or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 1 warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 1903 checkstyle errors (more than the master's current 1900 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +   * Wrapper method for {@link WaiterForTesting#waitFor(Configuration, long, long, boolean, Predicate)}.
+  public WaiterForTesting.Predicate<IOException> predicateTableAvailable(final TableName tableName) {
+    WaiterForTesting.waitFor(HTU.getConfiguration(), 1000, new WaiterForTesting.Predicate<Exception>() {
+    WaiterForTesting.waitFor(HTU.getConfiguration(), 1000, new WaiterForTesting.Predicate<Exception>() {
+      WaiterForTesting.waitFor(HTU.getConfiguration(), 90000, new WaiterForTesting.Predicate<Exception>() {

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13817//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13817//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13817//artifact/patchprocess/checkstyle-aggregate.html

                Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13817//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13817//console

This message is automatically generated.

> Make Waiter class a public API.
> -------------------------------
>
>                 Key: HBASE-13568
>                 URL: https://issues.apache.org/jira/browse/HBASE-13568
>             Project: HBase
>          Issue Type: Task
>            Reporter: Srikanth Srungarapu
>            Assignee: Srikanth Srungarapu
>            Priority: Minor
>         Attachments: HBASE-13568.patch
>
>
> During ProcV2 code reviews, it is suggested that Waiter class is useful enough to make it a public API. This change decomposes the existing Waiter class into two classes, one for public use and the other exclusively for the internal testing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)