[GitHub] [superset] ktmud commented on a change in pull request #18998: fix(plugin-chart-echarts): Apply temporary filters to Query B in explore

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #18998:
URL: https://github.com/apache/superset/pull/18998#discussion_r818931014



##########
File path: superset/utils/core.py
##########
@@ -1097,11 +1097,13 @@ def merge_extra_form_data(form_data: Dict[str, Any]) -> None:
         {"isExtra": True, **fltr} for fltr in append_adhoc_filters  # type: ignore
     )
     if append_filters:
-        adhoc_filters.extend(
-            simple_filter_to_adhoc({"isExtra": True, **fltr})  # type: ignore
-            for fltr in append_filters
-            if fltr
-        )
+        for key, value in form_data.items():
+            if re.match("adhoc_filter.*", key):
+                value.extend(
+                    simple_filter_to_adhoc({"isExtra": True, **fltr})  # type: ignore
+                    for fltr in append_filters
+                    if fltr
+                )

Review comment:
       ```suggestion
           for key in ["adhoc_filters", "adhoc_filters_b"]:
               form_data[key] = form_data.get(key, []) + [
                   simple_filter_to_adhoc({"isExtra": True, **fltr})  # type: ignore
                   for fltr in append_filters if fltr
               ]
   ```
   
   I think we can be more explicit about the field names to avoid looping through all form_data and a simple get can avoid db migration? Also, the extended value should be assigned back to `form_data` as L1091 may also see `adhoc_filters` not exists in `form_data`.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org