[GitHub] danny0405 commented on a change in pull request #958: [CALCITE-2674] SqlIdentifier same name with built-in function but with escape character should be still resolved as an identifier

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #958: [CALCITE-2674] SqlIdentifier same name with built-in function but with escape character should be still resolved as an identifier
URL: https://github.com/apache/calcite/pull/958#discussion_r261849378
 
 

 ##########
 File path: core/src/main/codegen/templates/Parser.jj
 ##########
 @@ -4157,20 +4154,22 @@ SqlDynamicParam DynamicParam() :
     }
 }
 
-
 /**
- * Parses a simple identifier as a string.
+ * Parses a dot(maybe) split identifier segment. Each time it reads an identifier it writes one element
 
 Review comment:
   @walterddr Sounds better comment, thx for the review.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services