You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by su...@apache.org on 2021/11/22 16:44:47 UTC
[druid] branch master updated: get rid of class cast exception and add a new testcase for that issue (#11951)
This is an automated email from the ASF dual-hosted git repository.
suneet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new a4cb1de get rid of class cast exception and add a new testcase for that issue (#11951)
a4cb1de is described below
commit a4cb1de87a53c12d235920c35ec397331e8a36b7
Author: TSFenwick <to...@imply.io>
AuthorDate: Mon Nov 22 08:44:20 2021 -0800
get rid of class cast exception and add a new testcase for that issue (#11951)
---
.../java/org/apache/druid/sql/avatica/ErrorHandler.java | 2 +-
.../org/apache/druid/sql/avatica/ErrorHandlerTest.java | 16 ++++++++++++++++
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/sql/src/main/java/org/apache/druid/sql/avatica/ErrorHandler.java b/sql/src/main/java/org/apache/druid/sql/avatica/ErrorHandler.java
index 62ab3c2..3a43d58 100644
--- a/sql/src/main/java/org/apache/druid/sql/avatica/ErrorHandler.java
+++ b/sql/src/main/java/org/apache/druid/sql/avatica/ErrorHandler.java
@@ -78,7 +78,7 @@ class ErrorHandler
return new RuntimeException(errorResponseTransformStrategy.transformIfNeeded((SanitizableException) error.getCause()));
}
QueryInterruptedException wrappedError = QueryInterruptedException.wrapIfNeeded(error);
- return (QueryInterruptedException) errorResponseTransformStrategy.transformIfNeeded(wrappedError);
+ return (QueryException) errorResponseTransformStrategy.transformIfNeeded(wrappedError);
}
/**
diff --git a/sql/src/test/java/org/apache/druid/sql/avatica/ErrorHandlerTest.java b/sql/src/test/java/org/apache/druid/sql/avatica/ErrorHandlerTest.java
index 68b7703..2efa65d 100644
--- a/sql/src/test/java/org/apache/druid/sql/avatica/ErrorHandlerTest.java
+++ b/sql/src/test/java/org/apache/druid/sql/avatica/ErrorHandlerTest.java
@@ -78,4 +78,20 @@ public class ErrorHandlerTest
ErrorHandler errorHandler = new ErrorHandler(serverConfig);
Assert.assertFalse(errorHandler.hasAffectingErrorResponseTransformStrategy());
}
+
+ @Test
+ public void testErrorHandlerHandlesNonSanitizableExceptionCorrectly()
+ {
+ ServerConfig serverConfig = Mockito.mock(ServerConfig.class);
+ AllowedRegexErrorResponseTransformStrategy emptyAllowedRegexErrorResponseTransformStrategy = new AllowedRegexErrorResponseTransformStrategy(
+ ImmutableList.of());
+
+ Mockito.when(serverConfig.getErrorResponseTransformStrategy())
+ .thenReturn(emptyAllowedRegexErrorResponseTransformStrategy);
+ ErrorHandler errorHandler = new ErrorHandler(serverConfig);
+
+ Exception input = new Exception("message");
+ RuntimeException output = errorHandler.sanitize(input);
+ Assert.assertEquals(null, output.getMessage());
+ }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org