You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/13 14:30:26 UTC
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1453: Ftr: Modify event dispatch interface and optimit dispatch functions
AlexStocks commented on a change in pull request #1453:
URL: https://github.com/apache/dubbo-go/pull/1453#discussion_r707391859
##########
File path: common/extension/config_loader_processor.go
##########
@@ -77,8 +77,9 @@ func ResetURL() {
// emit
func emit(funcName string, val []reflect.Value) {
+ var values []reflect.Value
for _, p := range GetConfigLoadProcessors() {
- values := []reflect.Value{reflect.ValueOf(p)}
+ values = []reflect.Value{reflect.ValueOf(p)}
Review comment:
没看出来你这样的改进有啥好处
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org