[GitHub] [ignite-3] PakhomovAlexander commented on a diff in pull request #2121: IGNITE-19565 Use JobClassLoader for loading job classes

["PakhomovAlexander (via GitHub)" <gi...@apache.org>]

PakhomovAlexander commented on code in PR #2121:
URL: https://github.com/apache/ignite-3/pull/2121#discussion_r1213344759


##########
modules/compute/src/main/java/org/apache/ignite/internal/compute/ComputeMessageTypes.java:
##########
@@ -35,4 +35,6 @@ public class ComputeMessageTypes {
      * Type for {@link ExecuteResponse}.
      */
     public static final short EXECUTE_RESPONSE = 1;
+
+    public static final short DEPLOYMENT_UNIT = 2;

Review Comment:
   add javadoc please



##########
modules/api/src/main/java/org/apache/ignite/compute/IgniteCompute.java:
##########
@@ -51,35 +41,7 @@ public interface IgniteCompute {
      * @param <R>      Job result type
      * @return CompletableFuture Job result.
      */
-    <R> CompletableFuture<R> execute(Set<ClusterNode> nodes, String jobClassName, Object... args);
-
-    /**
-     * Executes a job of the given class on the node where the given key is located. The node is a leader
-     * of the corresponding Raft group.
-     *
-     * @param tableName Name of the table whose key is used to determine the node to execute the job on.
-     * @param key Key that identifies the node to execute the job on.
-     * @param jobClass Class of the job to execute.
-     * @param args Arguments of the job.
-     * @param <R> Job result type.
-     * @return CompletableFuture Job result.
-     */
-    <R> CompletableFuture<R> executeColocated(String tableName, Tuple key, Class<? extends ComputeJob<R>> jobClass, Object... args);
-
-    /**
-     * Executes a job of the given class on the node where the given key is located. The node is a leader
-     * of the corresponding Raft group.
-     *
-     * @param tableName Name of the table whose key is used to determine the node to execute the job on.
-     * @param key Key that identifies the node to execute the job on.
-     * @param keyMapper Mapper used to map the key to a binary representation.
-     * @param jobClass Class of the job to execute.
-     * @param args Arguments of the job.
-     * @param <R> Job result type.
-     * @return CompletableFuture Job result.
-     */
-    <K, R> CompletableFuture<R> executeColocated(String tableName, K key, Mapper<K> keyMapper,
-                                                 Class<? extends ComputeJob<R>> jobClass, Object... args);
+    <R> CompletableFuture<R> execute(Set<ClusterNode> nodes, List<DeploymentUnit> units, String jobClassName, Object... args);

Review Comment:
   don't forget to update javadoc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org