You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/12 01:09:23 UTC
[GitHub] [hadoop-ozone] vivekratnavel opened a new pull request #1065: HDDS-3777. Reduce recon UI build time
vivekratnavel opened a new pull request #1065:
URL: https://github.com/apache/hadoop-ozone/pull/1065
## What changes were proposed in this pull request?
- Replace yarn as the default package manager to pnpm
- Replace -Dskip.yarn flag with -Dskip.npx
- Use caching in Github Actions workflow to cache node_modules and pnpm-store.
- Start running acceptance tests only after build succeeds
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3777
## How was this patch tested?
This patch was tested with several CI triggers. It reduces the recon build time significantly from ~16 minutes to less than 2 minutes.
Example run - https://github.com/vivekratnavel/hadoop-ozone/runs/763625356?check_suite_focus=true
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-commenter edited a comment on pull request #1065: HDDS-3777. Reduce recon UI build time
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1065:
URL: https://github.com/apache/hadoop-ozone/pull/1065#issuecomment-643027469
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=h1) Report
> Merging [#1065](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hadoop-ozone/commit/cee76a891b21ea50884ad8ba14461b31f60494ea&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1065 +/- ##
============================================
- Coverage 69.46% 69.39% -0.07%
+ Complexity 9121 9109 -12
============================================
Files 961 961
Lines 48151 48127 -24
Branches 4679 4676 -3
============================================
- Hits 33448 33400 -48
- Misses 12489 12512 +23
- Partials 2214 2215 +1
```
| [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...otocol/commands/RetriableDatanodeEventWatcher.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL3Byb3RvY29sL2NvbW1hbmRzL1JldHJpYWJsZURhdGFub2RlRXZlbnRXYXRjaGVyLmphdmE=) | `55.55% <0.00%> (-44.45%)` | `3.00% <0.00%> (-1.00%)` | |
| [...p/ozone/om/ratis/utils/OzoneManagerRatisUtils.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yYXRpcy91dGlscy9Pem9uZU1hbmFnZXJSYXRpc1V0aWxzLmphdmE=) | `67.44% <0.00%> (-19.13%)` | `39.00% <0.00%> (ø%)` | |
| [...che/hadoop/ozone/om/ratis/OMRatisSnapshotInfo.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yYXRpcy9PTVJhdGlzU25hcHNob3RJbmZvLmphdmE=) | `83.33% <0.00%> (-10.67%)` | `7.00% <0.00%> (-5.00%)` | |
| [...er/common/transport/server/GrpcXceiverService.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3RyYW5zcG9ydC9zZXJ2ZXIvR3JwY1hjZWl2ZXJTZXJ2aWNlLmphdmE=) | `70.00% <0.00%> (-10.00%)` | `3.00% <0.00%> (ø%)` | |
| [.../apache/hadoop/ozone/om/OMDBCheckpointServlet.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9PTURCQ2hlY2twb2ludFNlcnZsZXQuamF2YQ==) | `66.26% <0.00%> (-4.27%)` | `8.00% <0.00%> (-2.00%)` | |
| [...apache/hadoop/hdds/server/events/EventWatcher.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvZnJhbWV3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9zZXJ2ZXIvZXZlbnRzL0V2ZW50V2F0Y2hlci5qYXZh) | `77.77% <0.00%> (-4.17%)` | `14.00% <0.00%> (ø%)` | |
| [...ache/hadoop/hdds/scm/node/states/NodeStateMap.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL25vZGUvc3RhdGVzL05vZGVTdGF0ZU1hcC5qYXZh) | `74.35% <0.00%> (-2.57%)` | `16.00% <0.00%> (-1.00%)` | |
| [...va/org/apache/hadoop/ozone/lease/LeaseManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvbGVhc2UvTGVhc2VNYW5hZ2VyLmphdmE=) | `90.80% <0.00%> (-2.30%)` | `15.00% <0.00%> (-1.00%)` | |
| [...hdds/scm/container/common/helpers/ExcludeList.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9zY20vY29udGFpbmVyL2NvbW1vbi9oZWxwZXJzL0V4Y2x1ZGVMaXN0LmphdmE=) | `95.91% <0.00%> (-2.05%)` | `23.00% <0.00%> (-1.00%)` | |
| [...ine/commandhandler/DeleteBlocksCommandHandler.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3N0YXRlbWFjaGluZS9jb21tYW5kaGFuZGxlci9EZWxldGVCbG9ja3NDb21tYW5kSGFuZGxlci5qYXZh) | `62.50% <0.00%> (-1.57%)` | `9.00% <0.00%> (-2.00%)` | |
| ... and [24 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=footer). Last update [cee76a8...d2aa691](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on pull request #1065: HDDS-3777. Reduce recon UI build time
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on pull request #1065:
URL: https://github.com/apache/hadoop-ozone/pull/1065#issuecomment-643401727
@adoroszlai Thanks for the review! I have merged it now. If there is any issue, we can always revert it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1065: HDDS-3777. Reduce recon UI build time
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1065:
URL: https://github.com/apache/hadoop-ozone/pull/1065#discussion_r439235123
##########
File path: hadoop-ozone/recon/pom.xml
##########
@@ -86,37 +86,46 @@
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
+ <version>1.10.0</version>
Review comment:
This should be updated in the root pom instead:
https://github.com/apache/hadoop-ozone/blob/78255ddc7053bb470c7663993d5ce0aecd635f2d/pom.xml#L231
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-commenter commented on pull request #1065: HDDS-3777. Reduce recon UI build time
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1065:
URL: https://github.com/apache/hadoop-ozone/pull/1065#issuecomment-643027469
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=h1) Report
> Merging [#1065](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hadoop-ozone/commit/cee76a891b21ea50884ad8ba14461b31f60494ea&el=desc) will **decrease** coverage by `0.10%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1065 +/- ##
============================================
- Coverage 69.46% 69.35% -0.11%
+ Complexity 9121 9101 -20
============================================
Files 961 961
Lines 48151 48127 -24
Branches 4679 4676 -3
============================================
- Hits 33448 33380 -68
- Misses 12489 12527 +38
- Partials 2214 2220 +6
```
| [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...otocol/commands/RetriableDatanodeEventWatcher.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL296b25lL3Byb3RvY29sL2NvbW1hbmRzL1JldHJpYWJsZURhdGFub2RlRXZlbnRXYXRjaGVyLmphdmE=) | `55.55% <0.00%> (-44.45%)` | `3.00% <0.00%> (-1.00%)` | |
| [...p/ozone/om/ratis/utils/OzoneManagerRatisUtils.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yYXRpcy91dGlscy9Pem9uZU1hbmFnZXJSYXRpc1V0aWxzLmphdmE=) | `67.44% <0.00%> (-19.13%)` | `39.00% <0.00%> (ø%)` | |
| [...hdds/scm/container/common/helpers/ExcludeList.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9zY20vY29udGFpbmVyL2NvbW1vbi9oZWxwZXJzL0V4Y2x1ZGVMaXN0LmphdmE=) | `83.67% <0.00%> (-14.29%)` | `20.00% <0.00%> (-4.00%)` | |
| [...che/hadoop/ozone/om/ratis/OMRatisSnapshotInfo.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yYXRpcy9PTVJhdGlzU25hcHNob3RJbmZvLmphdmE=) | `83.33% <0.00%> (-10.67%)` | `7.00% <0.00%> (-5.00%)` | |
| [.../apache/hadoop/ozone/om/OMDBCheckpointServlet.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9PTURCQ2hlY2twb2ludFNlcnZsZXQuamF2YQ==) | `66.26% <0.00%> (-4.27%)` | `8.00% <0.00%> (-2.00%)` | |
| [...apache/hadoop/hdds/server/events/EventWatcher.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvZnJhbWV3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9zZXJ2ZXIvZXZlbnRzL0V2ZW50V2F0Y2hlci5qYXZh) | `77.77% <0.00%> (-4.17%)` | `14.00% <0.00%> (ø%)` | |
| [...che/hadoop/hdds/scm/pipeline/PipelineStateMap.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL3BpcGVsaW5lL1BpcGVsaW5lU3RhdGVNYXAuamF2YQ==) | `83.04% <0.00%> (-4.10%)` | `45.00% <0.00%> (-3.00%)` | |
| [...iner/common/statemachine/SCMConnectionManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3N0YXRlbWFjaGluZS9TQ01Db25uZWN0aW9uTWFuYWdlci5qYXZh) | `77.38% <0.00%> (-3.58%)` | `13.00% <0.00%> (-1.00%)` | |
| [...ache/hadoop/hdds/scm/node/states/NodeStateMap.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL25vZGUvc3RhdGVzL05vZGVTdGF0ZU1hcC5qYXZh) | `74.35% <0.00%> (-2.57%)` | `16.00% <0.00%> (-1.00%)` | |
| [...va/org/apache/hadoop/ozone/lease/LeaseManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvbGVhc2UvTGVhc2VNYW5hZ2VyLmphdmE=) | `90.80% <0.00%> (-2.30%)` | `15.00% <0.00%> (-1.00%)` | |
| ... and [20 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=footer). Last update [cee76a8...1dbdff8](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1065: HDDS-3777. Reduce recon UI build time
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1065:
URL: https://github.com/apache/hadoop-ozone/pull/1065#discussion_r439270950
##########
File path: hadoop-ozone/recon/pom.xml
##########
@@ -86,7 +86,7 @@
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
- <version>1.10.0</version>
+ <version>${frontend-maven-plugin.version}</version>
Review comment:
Nit: version is inherited from parent pom's `pluginManagement` section, no need to explicitly specify here. But it does no harm and can be removed later, it's more important to merge this speed improvement sooner than later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on pull request #1065: HDDS-3777. Reduce recon UI build time
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #1065:
URL: https://github.com/apache/hadoop-ozone/pull/1065#issuecomment-644131107
Thanks for the improvement.
(Note: As I remember the License generator for frontend was a built-in yarn feature. We might need to find the best npm based approach.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel merged pull request #1065: HDDS-3777. Reduce recon UI build time
Posted by GitBox <gi...@apache.org>.
vivekratnavel merged pull request #1065:
URL: https://github.com/apache/hadoop-ozone/pull/1065
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1065: HDDS-3777. Reduce recon UI build time
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1065:
URL: https://github.com/apache/hadoop-ozone/pull/1065#issuecomment-643239420
@elek can we merge this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] codecov-commenter edited a comment on pull request #1065: HDDS-3777. Reduce recon UI build time
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1065:
URL: https://github.com/apache/hadoop-ozone/pull/1065#issuecomment-643027469
# [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=h1) Report
> Merging [#1065](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=desc) into [master](https://codecov.io/gh/apache/hadoop-ozone/commit/cee76a891b21ea50884ad8ba14461b31f60494ea&el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1065 +/- ##
============================================
- Coverage 69.46% 69.34% -0.13%
+ Complexity 9121 9100 -21
============================================
Files 961 961
Lines 48151 48127 -24
Branches 4679 4676 -3
============================================
- Hits 33448 33372 -76
- Misses 12489 12537 +48
- Partials 2214 2218 +4
```
| [Impacted Files](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...hdds/scm/container/common/helpers/ExcludeList.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9zY20vY29udGFpbmVyL2NvbW1vbi9oZWxwZXJzL0V4Y2x1ZGVMaXN0LmphdmE=) | `75.51% <0.00%> (-22.45%)` | `18.00% <0.00%> (-6.00%)` | |
| [...p/ozone/om/ratis/utils/OzoneManagerRatisUtils.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yYXRpcy91dGlscy9Pem9uZU1hbmFnZXJSYXRpc1V0aWxzLmphdmE=) | `67.44% <0.00%> (-19.13%)` | `39.00% <0.00%> (ø%)` | |
| [...che/hadoop/ozone/om/ratis/OMRatisSnapshotInfo.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9yYXRpcy9PTVJhdGlzU25hcHNob3RJbmZvLmphdmE=) | `83.33% <0.00%> (-10.67%)` | `7.00% <0.00%> (-5.00%)` | |
| [.../apache/hadoop/ozone/om/OMDBCheckpointServlet.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9vbS9PTURCQ2hlY2twb2ludFNlcnZsZXQuamF2YQ==) | `66.26% <0.00%> (-4.27%)` | `8.00% <0.00%> (-2.00%)` | |
| [...apache/hadoop/hdds/server/events/EventWatcher.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvZnJhbWV3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3AvaGRkcy9zZXJ2ZXIvZXZlbnRzL0V2ZW50V2F0Y2hlci5qYXZh) | `77.77% <0.00%> (-4.17%)` | `14.00% <0.00%> (ø%)` | |
| [...che/hadoop/hdds/scm/pipeline/PipelineStateMap.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL3BpcGVsaW5lL1BpcGVsaW5lU3RhdGVNYXAuamF2YQ==) | `83.04% <0.00%> (-4.10%)` | `45.00% <0.00%> (-3.00%)` | |
| [...iner/common/statemachine/SCMConnectionManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29udGFpbmVyLXNlcnZpY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9jb250YWluZXIvY29tbW9uL3N0YXRlbWFjaGluZS9TQ01Db25uZWN0aW9uTWFuYWdlci5qYXZh) | `77.38% <0.00%> (-3.58%)` | `13.00% <0.00%> (-1.00%)` | |
| [...ache/hadoop/hdds/scm/node/states/NodeStateMap.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvc2VydmVyLXNjbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaGFkb29wL2hkZHMvc2NtL25vZGUvc3RhdGVzL05vZGVTdGF0ZU1hcC5qYXZh) | `74.35% <0.00%> (-2.57%)` | `16.00% <0.00%> (-1.00%)` | |
| [...PB/OzoneManagerProtocolServerSideTranslatorPB.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLW96b25lL296b25lLW1hbmFnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2hhZG9vcC9vem9uZS9wcm90b2NvbFBCL096b25lTWFuYWdlclByb3RvY29sU2VydmVyU2lkZVRyYW5zbGF0b3JQQi5qYXZh) | `80.48% <0.00%> (-2.44%)` | `16.00% <0.00%> (-1.00%)` | |
| [...va/org/apache/hadoop/ozone/lease/LeaseManager.java](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree#diff-aGFkb29wLWhkZHMvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9oYWRvb3Avb3pvbmUvbGVhc2UvTGVhc2VNYW5hZ2VyLmphdmE=) | `90.80% <0.00%> (-2.30%)` | `15.00% <0.00%> (-1.00%)` | |
| ... and [23 more](https://codecov.io/gh/apache/hadoop-ozone/pull/1065/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=footer). Last update [cee76a8...1dbdff8](https://codecov.io/gh/apache/hadoop-ozone/pull/1065?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on a change in pull request #1065: HDDS-3777. Reduce recon UI build time
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on a change in pull request #1065:
URL: https://github.com/apache/hadoop-ozone/pull/1065#discussion_r439253484
##########
File path: hadoop-ozone/recon/pom.xml
##########
@@ -86,37 +86,46 @@
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
+ <version>1.10.0</version>
Review comment:
Good catch! I Will fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org