You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/10/11 12:04:22 UTC
[GitHub] [incubator-devlake] likyh opened a new issue, #3364: [Refactor][config-ui] use correct var name
likyh opened a new issue, #3364:
URL: https://github.com/apache/incubator-devlake/issues/3364
## What and why to refactor
[What are you trying to refactor? Why should it be refactored now?](https://github.com/apache/incubator-devlake/blob/24804f67423a726d955003589cc93bb773db16b2/config-ui/src/hooks/useDataScopesManager.jsx#L750-L775)
Actually, `boardTransformations` and `projectTransformations` is `JiraBoard` array and project array.
## Describe the solution you'd like
use correct var name such as `projects` `projectList` or other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3364: [Refactor][config-ui] use correct var name
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3364:
URL: https://github.com/apache/incubator-devlake/issues/3364#issuecomment-1274985240
My point is though is that `projectTransformations` is intended to be a collection of Project Key IDs... _not_ Objects, an object is unintentionally being given to that set, and that's what's responsible for this behavior. This was only happening after the PR for Deployment Options was merged with the altered use of `entityIdKey`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3364: [Refactor][config-ui] use correct var name
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3364:
URL: https://github.com/apache/incubator-devlake/issues/3364#issuecomment-1274993771
The list get spreaded then reduced.... (`...projectTransformations`) so the `[cV]` key is supposed to be a valid entry after that point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation closed issue #3364: [Refactor][config-ui] use correct var name
Posted by GitBox <gi...@apache.org>.
e2corporation closed issue #3364: [Refactor][config-ui] use correct var name
URL: https://github.com/apache/incubator-devlake/issues/3364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #3364: [Refactor][config-ui] use correct var name
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #3364:
URL: https://github.com/apache/incubator-devlake/issues/3364#issuecomment-1274581848
`...projectTransformations.reduce(initializeTransformations, {})`: that is why `[object Object]` key exists in transfomation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #3364: [Refactor][config-ui] use correct var name
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #3364:
URL: https://github.com/apache/incubator-devlake/issues/3364#issuecomment-1275477626
@e2corporation This copy is wrong and another copy is right. So here set [object Object] into transformation here and another set by right key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #3364: [Refactor][config-ui] use correct var name
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #3364:
URL: https://github.com/apache/incubator-devlake/issues/3364#issuecomment-1274576026
I'll fix it in https://github.com/apache/incubator-devlake/issues/3328 's PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh commented on issue #3364: [Refactor][config-ui] use correct var name
Posted by GitBox <gi...@apache.org>.
likyh commented on issue #3364:
URL: https://github.com/apache/incubator-devlake/issues/3364#issuecomment-1274857708
It because this issue. projectTransformations is objects array. initializeTransformations use object as key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] e2corporation commented on issue #3364: [Refactor][config-ui] use correct var name
Posted by GitBox <gi...@apache.org>.
e2corporation commented on issue #3364:
URL: https://github.com/apache/incubator-devlake/issues/3364#issuecomment-1274809080
`[object Object]` is a result of the comment I made on the other ticket regarding use of `entityIdKey` inside an Effect. `projectTransformations` contains an invalid entry, this is why the reducer fails and ends up with Object.
The problem isn't a direct result of how this line is structured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org