You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2021/11/17 08:26:14 UTC

[camel] 01/02: CAMEL-17201: camel-kamelet-main - Auto download JARs for new components in use when using regular routes

This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git

commit ec7a3c294701f4145bcd0b67623f0e210c195425
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Wed Nov 17 08:28:46 2021 +0100

    CAMEL-17201: camel-kamelet-main - Auto download JARs for new components in use when using regular routes
---
 dsl/camel-kamelet-main/pom.xml                     |   4 +
 .../DependencyDownloaderComponentResolver.java     | 101 +++++++++++++++++++++
 .../camel/main/KameletDependencyDownloader.java    |   7 +-
 .../java/org/apache/camel/main/KameletMain.java    |   2 +
 4 files changed, 110 insertions(+), 4 deletions(-)

diff --git a/dsl/camel-kamelet-main/pom.xml b/dsl/camel-kamelet-main/pom.xml
index f6765af..1041be3 100644
--- a/dsl/camel-kamelet-main/pom.xml
+++ b/dsl/camel-kamelet-main/pom.xml
@@ -70,6 +70,10 @@
             <groupId>org.apache.camel</groupId>
             <artifactId>camel-yaml-dsl</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.apache.camel</groupId>
+            <artifactId>camel-catalog</artifactId>
+        </dependency>
 
         <dependency>
             <groupId>org.junit.jupiter</groupId>
diff --git a/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/DependencyDownloaderComponentResolver.java b/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/DependencyDownloaderComponentResolver.java
new file mode 100644
index 0000000..43b21da
--- /dev/null
+++ b/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/DependencyDownloaderComponentResolver.java
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.main;
+
+import java.net.URL;
+import java.net.URLClassLoader;
+import java.util.HashMap;
+import java.util.Map;
+
+import groovy.grape.Grape;
+import org.apache.camel.CamelContext;
+import org.apache.camel.CamelContextAware;
+import org.apache.camel.Component;
+import org.apache.camel.catalog.CamelCatalog;
+import org.apache.camel.catalog.DefaultCamelCatalog;
+import org.apache.camel.impl.engine.DefaultComponentResolver;
+import org.apache.camel.tooling.model.ComponentModel;
+import org.apache.camel.util.StopWatch;
+import org.apache.camel.util.TimeUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Auto downloaded needed JARs when resolving components.
+ */
+public class DependencyDownloaderComponentResolver extends DefaultComponentResolver implements CamelContextAware {
+
+    private static final Logger LOG = LoggerFactory.getLogger(KameletDependencyDownloader.class);
+    private final CamelCatalog catalog = new DefaultCamelCatalog();
+    private CamelContext camelContext;
+
+    public DependencyDownloaderComponentResolver(CamelContext camelContext) {
+        this.camelContext = camelContext;
+    }
+
+    @Override
+    public CamelContext getCamelContext() {
+        return camelContext;
+    }
+
+    @Override
+    public void setCamelContext(CamelContext camelContext) {
+        this.camelContext = camelContext;
+    }
+
+    @Override
+    public Component resolveComponent(String name, CamelContext context) {
+        ComponentModel model = catalog.componentModel(name);
+        if (model != null && !alreadyOnClasspath(model.getArtifactId())) {
+            downloadDependency(model.getGroupId(), model.getArtifactId(), model.getVersion());
+        }
+
+        return super.resolveComponent(name, context);
+    }
+
+    private boolean alreadyOnClasspath(String artifactId) {
+        if (camelContext.getApplicationContextClassLoader() != null) {
+            ClassLoader cl = camelContext.getApplicationContextClassLoader();
+            if (cl instanceof URLClassLoader) {
+                URLClassLoader ucl = (URLClassLoader) cl;
+                for (URL u : ucl.getURLs()) {
+                    String s = u.toString();
+                    if (s.contains(artifactId)) {
+                        // already on classpath
+                        return true;
+                    }
+                }
+            }
+        }
+        return false;
+    }
+
+    private void downloadDependency(String groupId, String artifactId, String version) {
+        StopWatch watch = new StopWatch();
+        Map<String, Object> map = new HashMap<>();
+        map.put("classLoader", camelContext.getApplicationContextClassLoader());
+        map.put("group", groupId);
+        map.put("module", artifactId);
+        map.put("version", version);
+        map.put("classifier", "");
+
+        LOG.debug("Downloading dependency: {}:{}:{}", groupId, artifactId, version);
+        Grape.grab(map);
+        LOG.info("Downloaded dependency: {}:{}:{} took: {}", groupId, artifactId, version,
+                TimeUtils.printDuration(watch.taken()));
+    }
+}
diff --git a/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/KameletDependencyDownloader.java b/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/KameletDependencyDownloader.java
index 59d7aa9..7e6b3cc 100644
--- a/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/KameletDependencyDownloader.java
+++ b/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/KameletDependencyDownloader.java
@@ -110,9 +110,8 @@ public class KameletDependencyDownloader extends YamlRoutesBuilderLoaderSupport
         }
 
         if (!gavs.isEmpty()) {
-            StopWatch watch = new StopWatch();
-            LOG.info("Downloading {} dependencies (may take some time)", gavs.size());
             for (String gav : gavs) {
+                StopWatch watch = new StopWatch();
                 MavenGav mg = MavenGav.parseGav(gav);
                 if (mg.getVersion() == null) {
                     mg.setVersion(camelContext.getVersion());
@@ -124,11 +123,11 @@ public class KameletDependencyDownloader extends YamlRoutesBuilderLoaderSupport
                 map.put("version", mg.getVersion());
                 map.put("classifier", "");
 
-                LOG.info("Downloading dependency: {}", mg);
+                LOG.debug("Downloading dependency: {}", mg);
                 Grape.grab(map);
                 downloaded.add(gav);
+                LOG.info("Downloaded dependency: {} took: {}", mg, TimeUtils.printDuration(watch.taken()));
             }
-            LOG.info("Downloaded {} dependencies took: {}", gavs.size(), TimeUtils.printDuration(watch.taken()));
         }
     }
 
diff --git a/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/KameletMain.java b/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/KameletMain.java
index c6f53c2..cb453ad 100644
--- a/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/KameletMain.java
+++ b/dsl/camel-kamelet-main/src/main/java/org/apache/camel/main/KameletMain.java
@@ -146,6 +146,8 @@ public class KameletMain extends MainCommandLineSupport {
         }
         answer.setApplicationContextClassLoader(kameletClassLoader);
         answer.setRegistry(registry);
+        // use component resolver that can auto downloaded JARs
+        answer.setComponentResolver(new DependencyDownloaderComponentResolver(answer));
 
         addInitialProperty("camel.component.kamelet.location", "classpath:/kamelets,github:apache:camel-kamelets");
         addInitialProperty("camel.main.lightweight", "true");