[GitHub] [geode] dschneider-pivotal commented on a change in pull request #6725: GEODE-9169: remove netty context switch

[GitBox <gi...@apache.org>]

dschneider-pivotal commented on a change in pull request #6725:
URL: https://github.com/apache/geode/pull/6725#discussion_r690673992



##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java
##########
@@ -257,8 +204,6 @@ public void channelInactive(ChannelHandlerContext ctx) {
         logger.debug("GeodeRedisServer-Connection closing with " + ctx.channel().remoteAddress());
       }
 
-      commandQueue.clear();
-      commandQueue.offer(TERMINATE_COMMAND);

Review comment:
       It looks like TERMINATE_COMMAND is no longer used. This class creates in a private static final so I think that static should also be removed

##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisServer.java
##########
@@ -94,7 +94,7 @@ public GeodeRedisServer(String bindAddress, int port, InternalCache cache) {
     nettyRedisServer = new NettyRedisServer(() -> cache.getInternalDistributedSystem().getConfig(),
         regionProvider, pubSub,
         this::allowUnsupportedCommands, this::shutdown, port, bindAddress, redisStats,
-        redisCommandExecutor, member);
+        member);

Review comment:
       shouldn't the redisCommandExecutor field be removed from this class?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org