You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/11/29 07:56:53 UTC

[GitHub] [hudi] nsivabalan opened a new pull request, #7324: [HUDI-5293] Fixing reader schema w/ Merge handle helper w/ schema on read enable + reconcile schema

nsivabalan opened a new pull request, #7324:
URL: https://github.com/apache/hudi/pull/7324

   ### Change Logs
   
   Commit1:
   schema.on.read enable
   
   commit2:
   schema.on.read.enable
   reconcile.schema
   
   commit 2 fails w/ 
   ```
   
   java.lang.IllegalArgumentException: cannot modify hudi meta col: _hoodie_commit_time
   	at org.apache.hudi.internal.schema.action.TableChange$BaseColumnChange.checkColModifyIsLegal(TableChange.java:157)
   	at org.apache.hudi.internal.schema.action.TableChanges$ColumnAddChange.addColumns(TableChanges.java:314)
   	at org.apache.hudi.internal.schema.utils.AvroSchemaEvolutionUtils.lambda$reconcileSchema$5(AvroSchemaEvolutionUtils.java:92)
   ```
   
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance impact._
   
   ### Risk level (write none, low medium or high below)
   
   _If medium or high, explain what verification was done to mitigate the risks._
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7324: [HUDI-5293] Fixing reader schema w/ Merge handle helper w/ schema on read enable + reconcile schema

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7324:
URL: https://github.com/apache/hudi/pull/7324#issuecomment-1330299362

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "82902016b8d975a735836a8d714c1f5819aefd44",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "82902016b8d975a735836a8d714c1f5819aefd44",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 82902016b8d975a735836a8d714c1f5819aefd44 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7324: [HUDI-5293] Fixing reader schema w/ Merge handle helper w/ schema on read enable + reconcile schema

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7324:
URL: https://github.com/apache/hudi/pull/7324#issuecomment-1330309001

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "82902016b8d975a735836a8d714c1f5819aefd44",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13312",
       "triggerID" : "82902016b8d975a735836a8d714c1f5819aefd44",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 82902016b8d975a735836a8d714c1f5819aefd44 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13312) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] nsivabalan closed pull request #7324: [HUDI-5293][WIP] Fixing reader schema w/ Merge handle helper w/ schema on read enable + reconcile schema

Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan closed pull request #7324: [HUDI-5293][WIP] Fixing reader schema w/ Merge handle helper w/ schema on read enable + reconcile schema
URL: https://github.com/apache/hudi/pull/7324


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] jonvex commented on pull request #7324: [HUDI-5293][WIP] Fixing reader schema w/ Merge handle helper w/ schema on read enable + reconcile schema

Posted by GitBox <gi...@apache.org>.
jonvex commented on PR #7324:
URL: https://github.com/apache/hudi/pull/7324#issuecomment-1371159746

   It seems like this was fixed by 7326. I tested the following steps in master and with 0.12.1 and it failed in 0.12.1 and worked in master
   
   ```
   create table test_table2 (
       id int,
       dt string,
       name string,
       price double,
       ts long
   ) using hudi
   tblproperties (
       primaryKey = 'id',
       type = 'cow',
       preCombineField = 'ts',
       'hoodie.datasource.meta.sync.enable' = 'false',
       'hoodie.datasource.hive_sync.enable' = 'false',
       'hoodie.schema.on.read.enable' = 'true'
   )
   partitioned by (dt)
   location '/tmp/schema_evo/test_table2';
   
   insert into test_table2 values
   (1, 'a1', 10, 100, "2021-01-05"),
   (2, 'a2', 20, 2000, "2021-01-06"),
   (3, 'a3', 30, 3000, "2021-01-07");
   
   set hoodie.datasource.write.reconcile.schema=true;
   
   insert into test_table2 values
   (4, 'a4', 14, 104, "2021-01-05"),
   (5, 'a5', 25, 2050, "2021-01-06"),
   (6, 'a6', 36, 3060, "2021-01-07");
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #7324: [HUDI-5293] Fixing reader schema w/ Merge handle helper w/ schema on read enable + reconcile schema

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7324:
URL: https://github.com/apache/hudi/pull/7324#issuecomment-1330736364

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "82902016b8d975a735836a8d714c1f5819aefd44",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13312",
       "triggerID" : "82902016b8d975a735836a8d714c1f5819aefd44",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 82902016b8d975a735836a8d714c1f5819aefd44 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=13312) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org