[GitHub] jmark99 opened a new pull request #476: ACCUMULO-2537 Add @Override Annotations

[GitBox <gi...@apache.org>]

jmark99 opened a new pull request #476: ACCUMULO-2537 Add @Override Annotations
URL: https://github.com/apache/accumulo/pull/476
 
 
   Added a profile 'overrides' to enforce use of the override annotation on
   required methods. Uses google errorprone to handle enforcement. It
   ignores the generated code in the project (i,e, thrift/proto/generated-sources).
    Findbugs/Spotbugs do not currently enable enforcement of the annotation,
    thus the use of errorprone. Initially setup as a profile to verify it works as expected
   and satisfies the goal of the annotation enforcement. Can be incorporated into 
   standard build in the future if desired. 
   
   Added the annotation to the necessary files in the process. Ignoring the generated
   code, there were not a huge number of missing annotations. There are currently 
   432 locations in the generated code that are missing the annotation.
   
   All other errorprone checks are disabled. There is a related ticket to examine 
   possible use of errorprone as a general error detecting tool.
   
   This pull request replaces Jira ticket ACCUMULO-2537.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services