You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org> on 2017/06/01 17:19:10 UTC
[Impala-ASF-CR] IMPALA-5411: Avoid log spew from GetRuntimeProfileStr
Bharath Vissapragada has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7042
Change subject: IMPALA-5411: Avoid log spew from GetRuntimeProfileStr
......................................................................
IMPALA-5411: Avoid log spew from GetRuntimeProfileStr
GetRuntimeProfileStr can potentially log lots of spam to the
coordinator logs if there are clients continuously polling the
web endpoints when the table metadata is still loading. The fix
is to use an appopriate Status constructor that doesn't log it.
Change-Id: I2d0ae8c161346b4ec8c865bc23c5c1cd49c1ce7b
---
M be/src/service/impala-server.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/7042/1
--
To view, visit http://gerrit.cloudera.org:8080/7042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d0ae8c161346b4ec8c865bc23c5c1cd49c1ce7b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
[Impala-ASF-CR] IMPALA-5411: Avoid log spew from GetRuntimeProfileStr
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5411: Avoid log spew from GetRuntimeProfileStr
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d0ae8c161346b4ec8c865bc23c5c1cd49c1ce7b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5411: Avoid log spew from GetRuntimeProfileStr
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5411: Avoid log spew from GetRuntimeProfileStr
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/665/
--
To view, visit http://gerrit.cloudera.org:8080/7042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d0ae8c161346b4ec8c865bc23c5c1cd49c1ce7b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5411: Avoid log spew from GetRuntimeProfileStr
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5411: Avoid log spew from GetRuntimeProfileStr
......................................................................
IMPALA-5411: Avoid log spew from GetRuntimeProfileStr
GetRuntimeProfileStr can potentially log lots of spam to the
coordinator logs if there are clients continuously polling the
web endpoints when the table metadata is still loading. The fix
is to use an appopriate Status constructor that doesn't log it.
Change-Id: I2d0ae8c161346b4ec8c865bc23c5c1cd49c1ce7b
Reviewed-on: http://gerrit.cloudera.org:8080/7042
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/service/impala-server.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Henry Robinson: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d0ae8c161346b4ec8c865bc23c5c1cd49c1ce7b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5411: Avoid log spew from GetRuntimeProfileStr
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5411: Avoid log spew from GetRuntimeProfileStr
......................................................................
Patch Set 1: Code-Review+2
I had no idea that Expected() existed... thanks!
--
To view, visit http://gerrit.cloudera.org:8080/7042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d0ae8c161346b4ec8c865bc23c5c1cd49c1ce7b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No