You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by yo...@apache.org on 2021/01/26 04:38:29 UTC
[superset] branch master updated: fix(explore): incorrect missing
datasource condition (#12758)
This is an automated email from the ASF dual-hosted git repository.
yongjiezhao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new ab741d7 fix(explore): incorrect missing datasource condition (#12758)
ab741d7 is described below
commit ab741d7218398353310e0ea0d1b1b296ee79b5fa
Author: Jesse Yang <je...@airbnb.com>
AuthorDate: Mon Jan 25 20:37:38 2021 -0800
fix(explore): incorrect missing datasource condition (#12758)
---
superset-frontend/src/explore/components/controls/DatasourceControl.jsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/superset-frontend/src/explore/components/controls/DatasourceControl.jsx b/superset-frontend/src/explore/components/controls/DatasourceControl.jsx
index 88e804d..e467f53 100644
--- a/superset-frontend/src/explore/components/controls/DatasourceControl.jsx
+++ b/superset-frontend/src/explore/components/controls/DatasourceControl.jsx
@@ -157,7 +157,7 @@ class DatasourceControl extends React.PureComponent {
render() {
const { showChangeDatasourceModal, showEditDatasourceModal } = this.state;
const { datasource, onChange } = this.props;
- const isMissingDatasource = datasource;
+ const isMissingDatasource = datasource.id == null;
const datasourceMenu = (
<Menu onClick={this.handleMenuItemClick}>
{this.props.isEditable && (