You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/03 13:13:46 UTC

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #45: Improve telnetd

patacongo commented on a change in pull request #45: Improve telnetd
URL: https://github.com/apache/incubator-nuttx-apps/pull/45#discussion_r374093618
 
 

 ##########
 File path: netutils/telnetd/telnetd_daemon.c
 ##########
 @@ -183,14 +181,12 @@ static int telnetd_daemon(int argc, FAR char *argv[])
 
   /* Set socket to reuse address */
 
-#ifdef CONFIG_NET_HAVE_REUSEADDR
 
 Review comment:
   Those are just hooks. The NuttX stack does not support SO_REUSEADDR.  So checking if an undefine-able configuration is defined is equivalent to #if 0
   
   I am not sure why it is removed here.  SO_REUSEADDR is not implemented.  Other than adding some code size, I suppose it does not matter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services