You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/30 06:57:51 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #24007: Cleanup `BranchDayOfWeekOperator` example dag

eladkal commented on code in PR #24007:
URL: https://github.com/apache/airflow/pull/24007#discussion_r884480270


##########
airflow/example_dags/example_branch_day_of_week_operator.py:
##########
@@ -33,8 +33,8 @@
     schedule_interval="@daily",
 ) as dag:

Review Comment:
   Looks like we can't :(
   
   ```
     _ test_should_be_importable[airflow/example_dags/example_branch_day_of_week_operator.py] _
     
     example = '/opt/airflow/airflow/example_dags/example_branch_day_of_week_operator.py'
     
         @pytest.mark.parametrize("example", example_dags(), ids=relative_path)
         def test_should_be_importable(example):
             dagbag = DagBag(
                 dag_folder=example,
                 include_examples=False,
             )
             assert len(dagbag.import_errors) == 0, f"import_errors={str(dagbag.import_errors)}"
     >       assert len(dagbag.dag_ids) >= 1
     E       assert 0 >= 1
     E        +  where 0 = len([])
     E        +    where [] = <airflow.models.dagbag.DagBag object at 0x7f2d5b506210>.dag_ids
     
     tests/always/test_example_dags.py:58: AssertionError
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org