[GitHub] bookkeeper issue #127: BOOKKEEPER-1028 and BOOKKEEPER-1029

[eolivelli <gi...@git.apache.org>]

Github user eolivelli commented on the issue:

    https://github.com/apache/bookkeeper/pull/127
  
    @reddycharan I have started a review.
    
    All tests run without failures on my laptop (after rebasing to current master)
    Apache Rat check is OK 
    
    But I see the findbugs errors below, can you fix them ?
    Maybe you can rebase to current master, now the full test suite runs in 20 minutes
    
    ```
    [INFO] Result of integer multiplication cast to long in org.apache.bookkeeper.bookie.BookieShell$DecommissionBookieCmd.waitForLedgersToBeReplicated(Collection, BookieSocketAddress, LedgerManager) [org.apache.bookkeeper.bookie.BookieShell$DecommissionBookieCmd] At BookieShell.java:[line 2081] ICAST_INTEGER_MULTIPLY_CAST_TO_LONG
    [INFO] Boxing/unboxing to parse a primitive org.apache.bookkeeper.bookie.BookieShell$LostBookieRecoveryDelayCmd.runCmd(CommandLine) [org.apache.bookkeeper.bookie.BookieShell$LostBookieRecoveryDelayCmd] At BookieShell.java:[line 1403] DM_BOXED_PRIMITIVE_FOR_PARSING
    [INFO] Boxing/unboxing to parse a primitive org.apache.bookkeeper.meta.ZkLedgerUnderreplicationManager.getLostBookieRecoveryDelay() [org.apache.bookkeeper.meta.ZkLedgerUnderreplicationManager] At ZkLedgerUnderreplicationManager.java:[line 741] DM_BOXED_PRIMITIVE_FOR_PARSING
    
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---