[GitHub] [accumulo] DomGarguilo commented on a change in pull request #2427: WIP - Migrate from JUnit 4 to JUnit 5

[GitBox <gi...@apache.org>]

DomGarguilo commented on a change in pull request #2427:
URL: https://github.com/apache/accumulo/pull/2427#discussion_r792685784



##########
File path: core/src/test/java/org/apache/accumulo/core/client/ZooKeeperInstanceTest.java
##########
@@ -128,33 +129,33 @@ public void testGetInstanceID_Direct() {
     assertEquals(IID_STRING, zki.getInstanceID());
   }
 
-  @Test(expected = RuntimeException.class)
+  @Test
   public void testGetInstanceID_NoMapping() {
     ClientConfiguration config = createMock(ClientConfiguration.class);
     expect(zc.get(Constants.ZROOT + Constants.ZINSTANCES + "/instance")).andReturn(null);
     replay(zc);
     EasyMock.reset(config, zcf);
-    new ZooKeeperInstance(config, zcf);
+    assertThrows(RuntimeException.class, () -> new ZooKeeperInstance(config, zcf));

Review comment:
       Do you think it would be a good idea to make a separate PR and take care of all of these cases first? Might make sense since even if we decide to not upgrade to JUnit 5 for whatever reason, that could still be a working improvement for our JUnit 4 tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org