You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2017/02/10 17:20:11 UTC
Review Request 56553: ATLAS-1550: for unit test failure in
TypeSystemTest.testDuplicateTypenames()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56553/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1550
https://issues.apache.org/jira/browse/ATLAS-1550
Repository: atlas
Description
-------
- updated the fix in ATLAS-1542 to ignore only duplicates in transientTypes i.e. types being added.
- any attempt to add an existing type will continue to fail
Diffs
-----
typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 119a8d5
typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java 175ba7e
Diff: https://reviews.apache.org/r/56553/diff/
Testing
-------
verified that unit tests pass
Thanks,
Madhan Neethiraj
Re: Review Request 56553: ATLAS-1550: for unit test failure in
TypeSystemTest.testDuplicateTypenames()
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56553/#review165144
-----------------------------------------------------------
Ship it!
Ship It!
- Suma Shivaprasad
On Feb. 10, 2017, 5:20 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56553/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 5:20 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1550
> https://issues.apache.org/jira/browse/ATLAS-1550
>
>
> Repository: atlas
>
>
> Description
> -------
>
> - updated the fix in ATLAS-1542 to ignore only duplicates in transientTypes i.e. types being added.
> - any attempt to add an existing type will continue to fail
>
>
> Diffs
> -----
>
> typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 119a8d5
> typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java 175ba7e
>
> Diff: https://reviews.apache.org/r/56553/diff/
>
>
> Testing
> -------
>
> verified that unit tests pass
>
>
> Thanks,
>
> Madhan Neethiraj
>
>